Add thread annotation macros with RTC_ prefix.

Add thread annotation macros with RTC_ prefix.
Update samples unittests to use RTC_ versions.

BUG=webrtc:8198
Review-Url: https://codereview.webrtc.org/3011973002
Cr-Commit-Position: refs/heads/master@{#19708}
Committed: https://chromium.googlesource.com/external/webrtc/+/5301e3c3db996feb4fd622d4449f740da1064477

[danilchap, 2017-09-06 10:17:26]

Description was changed from

==========
Add thread annotation macros with RTC_ prefix.

BUG=webrtc:8198
==========

to

==========
Add thread annotation macros with RTC_ prefix.
Update samples unittests to use RTC_ versions.

BUG=webrtc:8198
==========

[danilchap, 2017-09-06 10:20:58]

danilchap@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[danilchap, 2017-09-06 10:20:59]

Taking slower, but safer approach to avoid breaking chromium:
add new version, update all, only then remove old version.

[kwiberg-webrtc, 2017-09-06 10:31:56]

lgtm

https://codereview.webrtc.org/3011973002/diff/1/webrtc/rtc_base/thread_annota...
File webrtc/rtc_base/thread_annotations.h (right):

https://codereview.webrtc.org/3011973002/diff/1/webrtc/rtc_base/thread_annota...
webrtc/rtc_base/thread_annotations.h:40: #define RTC_GUARDED_VAR
RTC_THREAD_ANNOTATION_ATTRIBUTE__(guarded_var)
Instead of duplicating the definitions, you could do

  #define RTC_GUARDED_BY(x) RTC_THREAD_ANNOTATION_ATTRIBUTE__(guarded_by(x))
  #if !defined(GUARDED_BY)
  #define GUARDED_BY RTC_GUARDED_BY
  #endif

Not hugely important since this is going away very soon (right!?) and since
you've already written it another way. Still, easier to read.

[danilchap, 2017-09-06 10:36:41]

On 2017/09/06 10:31:56, kwiberg-webrtc wrote:
> lgtm
> 
>
https://codereview.webrtc.org/3011973002/diff/1/webrtc/rtc_base/thread_annota...
> File webrtc/rtc_base/thread_annotations.h (right):
> 
>
https://codereview.webrtc.org/3011973002/diff/1/webrtc/rtc_base/thread_annota...
> webrtc/rtc_base/thread_annotations.h:40: #define RTC_GUARDED_VAR
> RTC_THREAD_ANNOTATION_ATTRIBUTE__(guarded_var)
> Instead of duplicating the definitions, you could do
> 
>   #define RTC_GUARDED_BY(x) RTC_THREAD_ANNOTATION_ATTRIBUTE__(guarded_by(x))
>   #if !defined(GUARDED_BY)
>   #define GUARDED_BY RTC_GUARDED_BY
>   #endif
> 
> Not hugely important since this is going away very soon (right!?) and since
> you've already written it another way. Still, easier to read.

yes, hope to remove it soon enough, will keep in mind this construction for
other macro renaming

[danilchap, 2017-09-06 10:36:44]

The CQ bit was checked by danilchap@webrtc.org

[commit-bot: I haz the power, 2017-09-06 10:36:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-06 11:10:22]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1504694204710270, "parent_rev":
"2e75bd4ed8a6111f9bc5b71de23a1dee41137415", "commit_rev":
"5301e3c3db996feb4fd622d4449f740da1064477"}

[commit-bot: I haz the power, 2017-09-06 11:10:36]

Description was changed from

==========
Add thread annotation macros with RTC_ prefix.
Update samples unittests to use RTC_ versions.

BUG=webrtc:8198
==========

to

==========
Add thread annotation macros with RTC_ prefix.
Update samples unittests to use RTC_ versions.

BUG=webrtc:8198

Review-Url: https://codereview.webrtc.org/3011973002
Cr-Commit-Position: refs/heads/master@{#19708}
Committed:
https://chromium.googlesource.com/external/webrtc/+/5301e3c3db996feb4fd622d44...
==========

[commit-bot: I haz the power, 2017-09-06 11:10:37]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/5301e3c3db996feb4fd622d44...