Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 3011923002: Clean up Stats class used in VideoProcessor tests. (Closed)

Created:
3 years, 3 months ago by brandtr
Modified:
3 years, 3 months ago
Reviewers:
srte
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Clean up Stats class used in VideoProcessor tests. * Reorder and rename members of FrameStatistic. * Rename corresponding temp variables used in the summary calculations. * Make Stats class less structy. * Try to enforce consistent frame numbers at all times. * Remove VideoProcessor::FrameInfo struct and use the Stats class for keeping track of encode/decode start times, etc. BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/3011923002 Cr-Commit-Position: refs/heads/master@{#19703} Committed: https://chromium.googlesource.com/external/webrtc/+/8935d97f169d0c85ea04d2f370964f283783cd79

Patch Set 1 #

Patch Set 2 : Fix VS compile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -182 lines) Patch
M webrtc/modules/video_coding/codecs/test/stats.h View 1 chunk +34 lines, -27 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/stats.cc View 1 2 chunks +84 lines, -70 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/stats_unittest.cc View 1 chunk +8 lines, -12 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.h View 3 chunks +7 lines, -19 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.cc View 11 chunks +38 lines, -44 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
brandtr
Please take a look :)
3 years, 3 months ago (2017-09-05 08:18:32 UTC) #6
srte
lgtm
3 years, 3 months ago (2017-09-05 11:34:16 UTC) #7
srte
lgtm
3 years, 3 months ago (2017-09-05 11:34:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3011923002/80001
3 years, 3 months ago (2017-09-06 08:50:41 UTC) #19
commit-bot: I haz the power
3 years, 3 months ago (2017-09-06 08:53:29 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/8935d97f169d0c85ea04d2f37...

Powered by Google App Engine
This is Rietveld 408576698