Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 3011653003: Add a readme for the network tester. (Closed)

Created:
3 years, 3 months ago by tschumi
Modified:
3 years, 3 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add a readme for the network tester. BUG=None Review-Url: https://codereview.webrtc.org/3011653003 Cr-Commit-Position: refs/heads/master@{#19631} Committed: https://chromium.googlesource.com/external/webrtc/+/137cd1d788ea2630d5996d8e76cdcae410f014fb

Patch Set 1 #

Total comments: 2

Patch Set 2 : Respond to comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
A webrtc/rtc_tools/network_tester/README View 1 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
tschumi
3 years, 3 months ago (2017-08-31 09:26:32 UTC) #3
stefan-webrtc
lgtm https://codereview.webrtc.org/3011653003/diff/1/webrtc/rtc_tools/network_tester/README File webrtc/rtc_tools/network_tester/README (right): https://codereview.webrtc.org/3011653003/diff/1/webrtc/rtc_tools/network_tester/README#newcode7 webrtc/rtc_tools/network_tester/README:7: the decried network config. -a s/dcried/desired
3 years, 3 months ago (2017-08-31 11:33:36 UTC) #4
tschumi
https://codereview.webrtc.org/3011653003/diff/1/webrtc/rtc_tools/network_tester/README File webrtc/rtc_tools/network_tester/README (right): https://codereview.webrtc.org/3011653003/diff/1/webrtc/rtc_tools/network_tester/README#newcode7 webrtc/rtc_tools/network_tester/README:7: the decried network config. On 2017/08/31 11:33:35, stefan-webrtc wrote: ...
3 years, 3 months ago (2017-08-31 12:56:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3011653003/20001
3 years, 3 months ago (2017-08-31 12:57:04 UTC) #8
commit-bot: I haz the power
3 years, 3 months ago (2017-08-31 13:25:02 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/137cd1d788ea2630d5996d8e7...

Powered by Google App Engine
This is Rietveld 408576698