Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: webrtc/common_types.h

Issue 3011623002: Add new ANA stats to GetStats() to count the number of actions taken by each controller. (Closed)
Patch Set: Addressed review comments. Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/common_types.h
diff --git a/webrtc/common_types.h b/webrtc/common_types.h
index ac5c2e2e7b5aeaf7673a2b790c5cb0fd9ff69268..9e88d1f0e7b29e086af1f978278b473c4365a000 100644
--- a/webrtc/common_types.h
+++ b/webrtc/common_types.h
@@ -433,6 +433,18 @@ struct AudioDecodingCallStats {
int decoded_muted_output; // Number of calls returning a muted state output.
};
+// Statistics related to Audio Network Adaptation.
+struct ANAStats {
+ ANAStats();
+ ANAStats(const ANAStats&);
+ ~ANAStats();
hbos 2017/09/04 08:49:54 Is this a style-guide thing or can these be omitte
ossu 2017/09/04 11:23:02 Due to the Optional<> members, clang(-tidy) decide
+ rtc::Optional<int> bitrate_action_counter;
+ rtc::Optional<int> channel_action_counter;
+ rtc::Optional<int> dtx_action_counter;
+ rtc::Optional<int> fec_action_counter;
+ rtc::Optional<int> frame_length_action_counter;
hbos 2017/09/04 08:49:54 Please add comments explaining these. Also, prefe
ivoc 2017/09/04 15:48:00 Added comments and changed these to uint32_t.
+};
+
// ==================================================================
// Video specific types
// ==================================================================

Powered by Google App Engine
This is Rietveld 408576698