Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Side by Side Diff: webrtc/common_types.h

Issue 3011623002: Add new ANA stats to GetStats() to count the number of actions taken by each controller. (Closed)
Patch Set: Addressed review comments. Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 415 matching lines...) Expand 10 before | Expand all | Expand 10 after
426 int calls_to_silence_generator; // Number of calls where silence generated, 426 int calls_to_silence_generator; // Number of calls where silence generated,
427 // and NetEq was disengaged from decoding. 427 // and NetEq was disengaged from decoding.
428 int calls_to_neteq; // Number of calls to NetEq. 428 int calls_to_neteq; // Number of calls to NetEq.
429 int decoded_normal; // Number of calls where audio RTP packet decoded. 429 int decoded_normal; // Number of calls where audio RTP packet decoded.
430 int decoded_plc; // Number of calls resulted in PLC. 430 int decoded_plc; // Number of calls resulted in PLC.
431 int decoded_cng; // Number of calls where comfort noise generated due to DTX. 431 int decoded_cng; // Number of calls where comfort noise generated due to DTX.
432 int decoded_plc_cng; // Number of calls resulted where PLC faded to CNG. 432 int decoded_plc_cng; // Number of calls resulted where PLC faded to CNG.
433 int decoded_muted_output; // Number of calls returning a muted state output. 433 int decoded_muted_output; // Number of calls returning a muted state output.
434 }; 434 };
435 435
436 // Statistics related to Audio Network Adaptation.
437 struct ANAStats {
438 ANAStats();
439 ANAStats(const ANAStats&);
440 ~ANAStats();
hbos 2017/09/04 08:49:54 Is this a style-guide thing or can these be omitte
ossu 2017/09/04 11:23:02 Due to the Optional<> members, clang(-tidy) decide
441 rtc::Optional<int> bitrate_action_counter;
442 rtc::Optional<int> channel_action_counter;
443 rtc::Optional<int> dtx_action_counter;
444 rtc::Optional<int> fec_action_counter;
445 rtc::Optional<int> frame_length_action_counter;
hbos 2017/09/04 08:49:54 Please add comments explaining these. Also, prefe
ivoc 2017/09/04 15:48:00 Added comments and changed these to uint32_t.
446 };
447
436 // ================================================================== 448 // ==================================================================
437 // Video specific types 449 // Video specific types
438 // ================================================================== 450 // ==================================================================
439 451
440 // TODO(nisse): Delete, and switch to fourcc values everywhere? 452 // TODO(nisse): Delete, and switch to fourcc values everywhere?
441 // Supported video types. 453 // Supported video types.
442 enum class VideoType { 454 enum class VideoType {
443 kUnknown, 455 kUnknown,
444 kI420, 456 kI420,
445 kIYUV, 457 kIYUV,
(...skipping 519 matching lines...) Expand 10 before | Expand all | Expand 10 after
965 bool operator==(const RtpKeepAliveConfig& o) const { 977 bool operator==(const RtpKeepAliveConfig& o) const {
966 return timeout_interval_ms == o.timeout_interval_ms && 978 return timeout_interval_ms == o.timeout_interval_ms &&
967 payload_type == o.payload_type; 979 payload_type == o.payload_type;
968 } 980 }
969 bool operator!=(const RtpKeepAliveConfig& o) const { return !(*this == o); } 981 bool operator!=(const RtpKeepAliveConfig& o) const { return !(*this == o); }
970 }; 982 };
971 983
972 } // namespace webrtc 984 } // namespace webrtc
973 985
974 #endif // WEBRTC_COMMON_TYPES_H_ 986 #endif // WEBRTC_COMMON_TYPES_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698