Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: webrtc/common_types.h

Issue 3011623002: Add new ANA stats to GetStats() to count the number of actions taken by each controller. (Closed)
Patch Set: Added/updated links to issue. Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/call/audio_send_stream.h ('k') | webrtc/common_types.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/common_types.h
diff --git a/webrtc/common_types.h b/webrtc/common_types.h
index ac5c2e2e7b5aeaf7673a2b790c5cb0fd9ff69268..6ae34885f525d0891f74e5763567ea3b717ab5e2 100644
--- a/webrtc/common_types.h
+++ b/webrtc/common_types.h
@@ -433,6 +433,33 @@ struct AudioDecodingCallStats {
int decoded_muted_output; // Number of calls returning a muted state output.
};
+// Statistics related to Audio Network Adaptation.
+struct ANAStats {
kwiberg-webrtc 2017/09/08 08:09:49 The struct itself looks good, but is there somepla
kwiberg-webrtc 2017/09/08 08:11:47 Like in audio_encoder.h for example?
ivoc 2017/09/08 08:39:08 That makes sense, I wasn't aware this file is goin
ossu 2017/09/08 09:01:32 Did this struct just move all the way to common_ty
ivoc 2017/09/08 09:16:38 Indeed it did, behold the magic of code reviews :)
+ ANAStats();
+ ANAStats(const ANAStats&);
+ ~ANAStats();
+ // Number of actions taken by the ANA bitrate controller since the start of
+ // the call. If this value is not set, it indicates that the bitrate
+ // controller is disabled.
+ rtc::Optional<uint32_t> bitrate_action_counter;
+ // Number of actions taken by the ANA channel controller since the start of
+ // the call. If this value is not set, it indicates that the channel
+ // controller is disabled.
+ rtc::Optional<uint32_t> channel_action_counter;
+ // Number of actions taken by the ANA DTX controller since the start of the
+ // call. If this value is not set, it indicates that the DTX controller is
+ // disabled.
+ rtc::Optional<uint32_t> dtx_action_counter;
+ // Number of actions taken by the ANA FEC controller since the start of the
+ // call. If this value is not set, it indicates that the FEC controller is
+ // disabled.
+ rtc::Optional<uint32_t> fec_action_counter;
+ // Number of actions taken by the ANA frame length controller since the start
+ // of the call. If this value is not set, it indicates that the frame length
+ // controller is disabled.
+ rtc::Optional<uint32_t> frame_length_action_counter;
+};
+
// ==================================================================
// Video specific types
// ==================================================================
« no previous file with comments | « webrtc/call/audio_send_stream.h ('k') | webrtc/common_types.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698