Add new ANA stats to GetStats() to count the number of actions taken by each controller.

webrtc/common_types.h

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 415 matching lines @@
   int calls_to_silence_generator;  // Number of calls where silence generated,
                                    // and NetEq was disengaged from decoding.
   int calls_to_neteq;              // Number of calls to NetEq.
   int decoded_normal;  // Number of calls where audio RTP packet decoded.
   int decoded_plc;     // Number of calls resulted in PLC.
   int decoded_cng;  // Number of calls where comfort noise generated due to DTX.
   int decoded_plc_cng;  // Number of calls resulted where PLC faded to CNG.
   int decoded_muted_output;  // Number of calls returning a muted state output.
 };
 
+// Statistics related to Audio Network Adaptation.
+struct ANAStats {

[kwiberg-webrtc, 2017/09/08 08:09:49]

The struct itself looks good, but is there someplace else you could put it? All
the things in this file are going to have to find another home soon-ish, so not
adding more stuff feels like a good idea.

[kwiberg-webrtc, 2017/09/08 08:11:47]

Like in audio_encoder.h for example?

[ivoc, 2017/09/08 08:39:08]

That makes sense, I wasn't aware this file is going away. I put the struct in
audio_encoder.h like you suggested.

[ossu, 2017/09/08 09:01:32]

Did this struct just move all the way to common_types.h and back again, changing
its name on the way? :)

(I'm fine with that BTW - just an observation)

[ivoc, 2017/09/08 09:16:38]

Indeed it did, behold the magic of code reviews :) I think it makes sense to
have it here though, and there were many other improvements along the way.

+  ANAStats();
+  ANAStats(const ANAStats&);
+  ~ANAStats();
+  // Number of actions taken by the ANA bitrate controller since the start of
+  // the call. If this value is not set, it indicates that the bitrate
+  // controller is disabled.
+  rtc::Optional<uint32_t> bitrate_action_counter;
+  // Number of actions taken by the ANA channel controller since the start of
+  // the call. If this value is not set, it indicates that the channel
+  // controller is disabled.
+  rtc::Optional<uint32_t> channel_action_counter;
+  // Number of actions taken by the ANA DTX controller since the start of the
+  // call. If this value is not set, it indicates that the DTX controller is
+  // disabled.
+  rtc::Optional<uint32_t> dtx_action_counter;
+  // Number of actions taken by the ANA FEC controller since the start of the
+  // call. If this value is not set, it indicates that the FEC controller is
+  // disabled.
+  rtc::Optional<uint32_t> fec_action_counter;
+  // Number of actions taken by the ANA frame length controller since the start
+  // of the call. If this value is not set, it indicates that the frame length
+  // controller is disabled.
+  rtc::Optional<uint32_t> frame_length_action_counter;
+};
+
 // ==================================================================
 // Video specific types
 // ==================================================================
 
 // TODO(nisse): Delete, and switch to fourcc values everywhere?
 // Supported video types.
 enum class VideoType {
   kUnknown,
   kI420,
   kIYUV,
@@ skipping 519 matching lines @@
   bool operator==(const RtpKeepAliveConfig& o) const {
     return timeout_interval_ms == o.timeout_interval_ms &&
            payload_type == o.payload_type;
   }
   bool operator!=(const RtpKeepAliveConfig& o) const { return !(*this == o); }
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_COMMON_TYPES_H_