Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Unified Diff: telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py

Issue 3011383002: [Telemetry] Explicitly disable ModalPermissionPrompts on Android (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py
diff --git a/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py b/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py
index 8cc36b46d5b11890856a3acb8efd2c325147aec2..18f87b89dbd2383c4a5e887d33190964d9cd25d4 100644
--- a/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py
+++ b/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py
@@ -84,6 +84,9 @@ class ChromeBrowserBackend(browser_backend.BrowserBackend):
args[i] = re.sub(r',\w+<PermissionPromptUIAndroidModal\b', '', arg)
elif arg.startswith('--force-fieldtrials='):
args[i] = re.sub(r'\bPermissionPromptUIAndroidModal/\w+/', '', arg)
+ elif arg.startswith('--disable-features='):
+ args[i] = ','.join([
+ args[i], 'ModalPermissionPrompts<PermissionPromptUIAndroidModal'])
args.append('--enable-net-benchmarking')
args.append('--metrics-recording-only')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698