Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 3011383002: [Telemetry] Explicitly disable ModalPermissionPrompts on Android (Closed)

Created:
3 years, 3 months ago by perezju
Modified:
3 years, 3 months ago
Reviewers:
nednguyen, Timothy Loh
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org, CalebRouleau
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Explicitly disable ModalPermissionPrompts on Android As of https://crrev.com/501859, this feature is now enabled by default, so Telmetry needs to explicitly disable it to turn it off. BUG=chromium:760901 Review-Url: https://chromiumcodereview.appspot.com/3011383002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/a298cb5159d0324e39ae160e1755540d045a46f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
perezju
3 years, 3 months ago (2017-09-20 13:13:51 UTC) #2
perezju
Confirmed through local testing that this makes the dialogs non-modal again.
3 years, 3 months ago (2017-09-20 13:15:30 UTC) #3
nednguyen
lgtm cc'ed Caleb as he is planning to improve the way we manager browser commandline ...
3 years, 3 months ago (2017-09-20 13:33:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3011383002/1
3 years, 3 months ago (2017-09-20 13:36:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/a298cb5159d0324e39ae160e1755540d045a46f6
3 years, 3 months ago (2017-09-20 14:08:45 UTC) #10
Timothy Loh
3 years, 3 months ago (2017-09-21 00:37:14 UTC) #11
Message was sent while issue was closed.
On 2017/09/20 14:08:45, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Thanks! Sorry for the breakage.

Powered by Google App Engine
This is Rietveld 408576698