Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 3011323002: Rollback of "Use small BWE period when there is a true network degradation" (Closed)

Created:
3 years, 3 months ago by alexnarest
Modified:
3 years, 3 months ago
Reviewers:
ivoc, stefan-webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

This is a rollback of https://chromium-review.googlesource.com/c/external/webrtc/+/616724 it degraded results of the ANA testing BUG=webrtc:8105 Review-Url: https://codereview.webrtc.org/3011323002 Cr-Commit-Position: refs/heads/master@{#19902} Committed: https://webrtc.googlesource.com/src/+/b335e31bcb16f53883c7d205daf25f0dc1fe2662

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -37 lines) Patch
M modules/congestion_controller/delay_based_bwe_unittest.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M modules/remote_bitrate_estimator/aimd_rate_control.cc View 2 chunks +5 lines, -13 lines 0 comments Download
M modules/remote_bitrate_estimator/aimd_rate_control_unittest.cc View 5 chunks +9 lines, -24 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
alexnarest
PTAL
3 years, 3 months ago (2017-09-15 14:56:57 UTC) #3
ivoc
lgtm. Please add BUG=webrtc:8105 to the description.
3 years, 3 months ago (2017-09-15 15:08:03 UTC) #4
stefan-webrtc
lgtm
3 years, 3 months ago (2017-09-19 18:28:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3011323002/1
3 years, 3 months ago (2017-09-19 18:28:20 UTC) #8
commit-bot: I haz the power
3 years, 3 months ago (2017-09-19 19:00:39 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://webrtc.googlesource.com/src/+/b335e31bcb16f53883c7d205daf25f0dc1fe2662

Powered by Google App Engine
This is Rietveld 408576698