Move reencode logic for screenshare bitrate overshoot from generic

Move reencode logic for screenshare bitrate overshoot from generic
encoder to vp8impl.
BUG=none

Review-Url: https://codereview.webrtc.org/3011213002
Cr-Commit-Position: refs/heads/master@{#19803}
Committed: https://chromium.googlesource.com/external/webrtc/+/e99738174344a7d172d9391f3bd9f485b9e64d67

[ilnik, 2017-09-12 12:50:04]

The CQ bit was checked by ilnik@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-09-12 12:50:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[ilnik, 2017-09-12 12:52:01]

https://codereview.webrtc.org/3011213002/diff/1/webrtc/modules/video_coding/g...
File webrtc/modules/video_coding/generic_encoder.cc (right):

https://codereview.webrtc.org/3011213002/diff/1/webrtc/modules/video_coding/g...
webrtc/modules/video_coding/generic_encoder.cc:90: RTC_NOTREACHED();
Should we leave this here? What if libvpx return overshoot again on the
reencoding attempt?

[ilnik, 2017-09-12 13:16:39]

ilnik@webrtc.org changed reviewers:
+ sprang@webrtc.org

[commit-bot: I haz the power, 2017-09-12 13:23:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-12 13:23:03]

Dry run: This issue passed the CQ dry run.

[sprang_webrtc, 2017-09-12 14:17:11]

https://codereview.webrtc.org/3011213002/diff/1/webrtc/modules/video_coding/g...
File webrtc/modules/video_coding/generic_encoder.cc (right):

https://codereview.webrtc.org/3011213002/diff/1/webrtc/modules/video_coding/g...
webrtc/modules/video_coding/generic_encoder.cc:90: RTC_NOTREACHED();
On 2017/09/12 12:52:00, ilnik wrote:
> Should we leave this here? What if libvpx return overshoot again on the
> reencoding attempt?

It should not, and we don't want to get stuck in a loop. VP9 also already does
this drop-re-encode logic internally.
I suggest removing this if-statement entirely and just return Encode() result
immediately.

Also, if we do that, check if is_screenshare_ is now unused and can be removed.

[ilnik, 2017-09-12 14:34:58]

https://codereview.webrtc.org/3011213002/diff/1/webrtc/modules/video_coding/g...
File webrtc/modules/video_coding/generic_encoder.cc (right):

https://codereview.webrtc.org/3011213002/diff/1/webrtc/modules/video_coding/g...
webrtc/modules/video_coding/generic_encoder.cc:90: RTC_NOTREACHED();
On 2017/09/12 14:17:11, sprang_webrtc wrote:
> On 2017/09/12 12:52:00, ilnik wrote:
> > Should we leave this here? What if libvpx return overshoot again on the
> > reencoding attempt?
> 
> It should not, and we don't want to get stuck in a loop. VP9 also already does
> this drop-re-encode logic internally.
> I suggest removing this if-statement entirely and just return Encode() result
> immediately.
> 
> Also, if we do that, check if is_screenshare_ is now unused and can be
removed.

Done.

[sprang_webrtc, 2017-09-12 15:24:18]

lgtm

[ilnik, 2017-09-12 16:58:49]

The CQ bit was checked by ilnik@webrtc.org

[commit-bot: I haz the power, 2017-09-12 16:58:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-12 17:24:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1505235529221080,
"parent_rev": "005b5ec3cc9a14135f7869d1a77b7a918fce2fab", "commit_rev":
"e99738174344a7d172d9391f3bd9f485b9e64d67"}

[commit-bot: I haz the power, 2017-09-12 17:24:52]

Description was changed from

==========
Move reencode logic for screenshare bitrate overshoot from generic
encoder to vp8impl.
BUG=none
==========

to

==========
Move reencode logic for screenshare bitrate overshoot from generic
encoder to vp8impl.
BUG=none

Review-Url: https://codereview.webrtc.org/3011213002
Cr-Commit-Position: refs/heads/master@{#19803}
Committed:
https://chromium.googlesource.com/external/webrtc/+/e99738174344a7d172d9391f3...
==========

[commit-bot: I haz the power, 2017-09-12 17:25:03]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/e99738174344a7d172d9391f3...