Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: webrtc/pc/peerconnectioninterface_unittest.cc

Issue 3011133002: Remove the support of fallback from DTLS to SDES. (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/p2p/base/transportdescriptionfactory.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/pc/peerconnectioninterface_unittest.cc
diff --git a/webrtc/pc/peerconnectioninterface_unittest.cc b/webrtc/pc/peerconnectioninterface_unittest.cc
index c23a79d597b4fe8bdaec83edbd867df52ef3f3f5..64071cae9ec1ee7a019a759d9a8ef223eb7e8e5e 100644
--- a/webrtc/pc/peerconnectioninterface_unittest.cc
+++ b/webrtc/pc/peerconnectioninterface_unittest.cc
@@ -2248,10 +2248,8 @@ TEST_F(PeerConnectionInterfaceTest, ReceiveFireFoxOffer) {
#endif
}
-// Test that an offer can be received which offers DTLS with SDES fallback.
-// Regression test for issue:
-// https://bugs.chromium.org/p/webrtc/issues/detail?id=6972
-TEST_F(PeerConnectionInterfaceTest, ReceiveDtlsSdesFallbackOffer) {
+// Test that fallback from DTLS to SDES is not supported.
Taylor Brandstetter 2017/09/11 20:31:16 Can you mention in the comment that this functiona
+TEST_F(PeerConnectionInterfaceTest, DtlsSdesFallbackNotSupport) {
Taylor Brandstetter 2017/09/11 20:31:16 nit: "NotSupported" instead of "NotSupport"
FakeConstraints constraints;
constraints.AddMandatory(webrtc::MediaConstraintsInterface::kEnableDtlsSrtp,
true);
@@ -2264,8 +2262,7 @@ TEST_F(PeerConnectionInterfaceTest, ReceiveDtlsSdesFallbackOffer) {
kTimeout);
SessionDescriptionInterface* desc = webrtc::CreateSessionDescription(
SessionDescriptionInterface::kOffer, kDtlsSdesFallbackSdp, nullptr);
- EXPECT_TRUE(DoSetSessionDescription(desc, false));
- CreateAnswerAsLocalDescription();
+ EXPECT_FALSE(DoSetSessionDescription(desc, false));
}
// Test that we can create an audio only offer and receive an answer with a
« no previous file with comments | « webrtc/p2p/base/transportdescriptionfactory.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698