Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h

Issue 3011013002: Improve the style of the objc wrapper for PeerConnectionInterface::SetBitrate. (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h
diff --git a/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h
index ce2df4d7f5ee568aae626aed1b50a353fa3165e2..4c6cec6b466870c561d7c1a2be5d86b4b0c49341 100644
--- a/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h
+++ b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h
@@ -184,12 +184,15 @@ RTC_EXPORT
completionHandler:
(nullable void (^)(NSError * _Nullable error))completionHandler;
-/** Updates bandwidth estimation parameters. Null parameters will be unchanged.
- * Returns true iff the parameters were successfully updated.
+/**
+ * Limits the bandwidth allocated for all RTP streams sent by this
tkchin_webrtc 2017/09/05 20:51:51 nit: move first word after /** to match methods ab
Zach Stein 2017/09/05 21:14:41 Done.
+ * PeerConnection. Nil parameters will be unchanged. Setting
+ * |currentBitrateBps| will force the available bitrate estimate to the given
tkchin_webrtc 2017/09/05 20:51:51 for my own education - will bitrate estimate conti
Zach Stein 2017/09/05 21:14:41 Yes.
+ * value. Returns YES if the parameters were successfully updated.
*/
-- (BOOL)setBitrateToMin:(NSNumber *_Nullable)minBitrateBps
- toCurrent:(NSNumber *_Nullable)currentBitrateBps
- toMax:(NSNumber *_Nullable)maxBitrateBps;
+- (BOOL)setBweMinBitrateBps:(nullable NSNumber *)minBitrateBps
+ currentBitrateBps:(nullable NSNumber *)currentBitrateBps
+ maxBitrateBps:(nullable NSNumber *)maxBitrateBps;
/** Start or stop recording an Rtc EventLog. */
- (BOOL)startRtcEventLogWithFilePath:(NSString *)filePath

Powered by Google App Engine
This is Rietveld 408576698