Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 3010983002: Revert of Use RtxReceiveStream. (Closed)

Created:
3 years, 3 months ago by nisse-webrtc
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Use RtxReceiveStream. (patchset #5 id:80001 of https://codereview.webrtc.org/3008773002/ ) Reason for revert: A few perf tests broken, including RampUpTest.UpDownUpAbsSendTimeSimulcastRedRtx RampUpTest.UpDownUpTransportSequenceNumberRtx RampUpTest.UpDownUpTransportSequenceNumberPacketLoss Original issue's description: > Use RtxReceiveStream. > > This also has the beneficial side-effect that when a media stream > which is protected by FlexFEC receives an RTX retransmission, the > retransmitted media packet is passed into the FlexFEC machinery, > which should improve its ability to recover packets via FEC. > > BUG=webrtc:7135 > > Review-Url: https://codereview.webrtc.org/3008773002 > Cr-Commit-Position: refs/heads/master@{#19649} > Committed: https://chromium.googlesource.com/external/webrtc/+/5c0f6c62ea3b1d2c43f8fc152961af27033475f7 TBR=brandtr@webrtc.org,danilchap@webrtc.org,stefan@webrtc.org,magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7135 Review-Url: https://codereview.webrtc.org/3010983002 Cr-Commit-Position: refs/heads/master@{#19653} Committed: https://chromium.googlesource.com/external/webrtc/+/3c39c0137afa274d1d524b150b50304b38a2847b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -72 lines) Patch
M webrtc/call/rampup_tests.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/call/video_receive_stream.h View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine_unittest.cc View 5 chunks +13 lines, -41 lines 0 comments Download
M webrtc/video/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/video/rtp_video_stream_receiver.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/video/rtp_video_stream_receiver.cc View 4 chunks +36 lines, -2 lines 0 comments Download
M webrtc/video/video_receive_stream.h View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 4 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
nisse-webrtc
Created Revert of Use RtxReceiveStream.
3 years, 3 months ago (2017-09-04 11:22:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3010983002/1
3 years, 3 months ago (2017-09-04 11:22:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/3c39c0137afa274d1d524b150b50304b38a2847b
3 years, 3 months ago (2017-09-04 11:22:22 UTC) #6
nisse-webrtc
3 years, 3 months ago (2017-09-04 12:26:32 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/3006063002/ by nisse@webrtc.org.

The reason for reverting is: Intend to fix perf failures and reland..

Powered by Google App Engine
This is Rietveld 408576698