Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 3010973002: Resolves crash in AudioTrack.flush() on Android (Closed)

Created:
3 years, 3 months ago by henrika_webrtc
Modified:
3 years, 3 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Resolves crash in AudioTrack.flush() on Android. BUG=b/65286737 Review-Url: https://codereview.webrtc.org/3010973002 Cr-Commit-Position: refs/heads/master@{#19706} Committed: https://chromium.googlesource.com/external/webrtc/+/789825c42d2d93763b7d54454cd46e502c037592

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebased #

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java View 1 2 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
henrika_webrtc
We actually don' need to call flush() after stop() since it is done as part ...
3 years, 3 months ago (2017-09-04 10:45:06 UTC) #5
AlexG
lgtm https://codereview.webrtc.org/3010973002/diff/1/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java File webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java (right): https://codereview.webrtc.org/3010973002/diff/1/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java#newcode180 webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java:180: audioTrack.stop(); at.stop() ? or may be get rid ...
3 years, 3 months ago (2017-09-05 17:05:17 UTC) #8
henrika_webrtc
https://codereview.webrtc.org/3010973002/diff/1/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java File webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java (right): https://codereview.webrtc.org/3010973002/diff/1/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java#newcode180 webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java:180: audioTrack.stop(); Thanks. Done.
3 years, 3 months ago (2017-09-06 09:22:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3010973002/40001
3 years, 3 months ago (2017-09-06 09:23:10 UTC) #12
commit-bot: I haz the power
3 years, 3 months ago (2017-09-06 09:58:38 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/789825c42d2d93763b7d54454...

Powered by Google App Engine
This is Rietveld 408576698