Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 3010953002: Revert of Prepare for injectable SW decoders (Closed)

Created:
3 years, 3 months ago by perkj_webrtc
Modified:
3 years, 3 months ago
Reviewers:
magjed_webrtc, andersc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Prepare for injectable SW decoders (patchset #3 id:40001 of https://codereview.webrtc.org/3009973002/ ) Reason for revert: Tentative revert since it seems to cause problems in Chrome, MAC. https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Tester/builds/42684 Original issue's description: > Prepare for injectable SW decoders > > Pretty much mirrors the work done on the encoding side in CLs: > > "Clean up ownership of webrtc::VideoEncoder" > https://codereview.webrtc.org/3007643002/ > > "Let VideoEncoderSoftwareFallbackWrapper own the wrapped encoder" > https://codereview.webrtc.org/3007683002/ > > "WebRtcVideoEngine: Encapsulate logic for unifying internal and external video codecs" > https://codereview.webrtc.org/3006713002/ > > BUG=webrtc:7925 > > Review-Url: https://codereview.webrtc.org/3009973002 > Cr-Commit-Position: refs/heads/master@{#19641} > Committed: https://chromium.googlesource.com/external/webrtc/+/084c55a63a2d9bdc71579458406d44f8bab9f454 TBR=magjed@webrtc.org,andersc@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7925 Review-Url: https://codereview.webrtc.org/3010953002 Cr-Commit-Position: refs/heads/master@{#19647} Committed: https://chromium.googlesource.com/external/webrtc/+/1f88531038c24c5ce3b0f4cfc682b970770a71f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -298 lines) Patch
M webrtc/media/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/media/engine/scopedvideodecoder.h View 1 chunk +0 lines, -37 lines 0 comments Download
D webrtc/media/engine/scopedvideodecoder.cc View 1 chunk +0 lines, -110 lines 0 comments Download
M webrtc/media/engine/videodecodersoftwarefallbackwrapper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/media/engine/videodecodersoftwarefallbackwrapper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/media/engine/videodecodersoftwarefallbackwrapper_unittest.cc View 6 chunks +37 lines, -41 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine.h View 7 chunks +23 lines, -12 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine.cc View 15 chunks +73 lines, -91 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
perkj_webrtc
Created Revert of Prepare for injectable SW decoders
3 years, 3 months ago (2017-09-04 07:45:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3010953002/1
3 years, 3 months ago (2017-09-04 07:45:14 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/1f88531038c24c5ce3b0f4cfc682b970770a71f6
3 years, 3 months ago (2017-09-04 09:43:26 UTC) #6
andersc
3 years, 3 months ago (2017-09-11 13:42:10 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/3005363002/ by andersc@webrtc.org.

The reason for reverting is: Fix bug introduced by keeping the allocated
decoders in a map..

Powered by Google App Engine
This is Rietveld 408576698