Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 3010743002: Refactor RTX video codec and payload type assignment (Closed)

Created:
3 years, 3 months ago by magjed_webrtc
Modified:
3 years, 3 months ago
Reviewers:
andersc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Refactor RTX video codec and payload type assignment We want to reuse some of this functionality for the new video codec factories, but not of all it, so this CL refactors out what we want to reuse to a static function. BUG=webrtc:7925 Review-Url: https://codereview.webrtc.org/3010743002 Cr-Commit-Position: refs/heads/master@{#19628} Committed: https://chromium.googlesource.com/external/webrtc/+/6ed63255cab783e7dbeea8a8deadfc27fa6abde7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -53 lines) Patch
M webrtc/media/engine/webrtcvideoengine.cc View 2 chunks +33 lines, -53 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
magjed_webrtc
Anders - please take a look.
3 years, 3 months ago (2017-08-30 14:38:09 UTC) #9
andersc
On 2017/08/30 14:38:09, magjed_webrtc wrote: > Anders - please take a look. Nice, I find ...
3 years, 3 months ago (2017-08-31 08:52:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3010743002/20001
3 years, 3 months ago (2017-08-31 12:34:34 UTC) #14
commit-bot: I haz the power
3 years, 3 months ago (2017-08-31 12:37:11 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/6ed63255cab783e7dbeea8a8d...

Powered by Google App Engine
This is Rietveld 408576698