Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
3010633002:
Remove backwards compatibilty header for ArrayView (Closed)
|
Created:
3 years, 3 months ago by kwiberg-webrtc Modified:
3 years, 3 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRemove backwards compatibilty header for ArrayView
BUG=webrtc:8205
Review-Url: https://codereview.webrtc.org/3010633002
Cr-Commit-Position: refs/heads/master@{#19884}
Committed: https://webrtc.googlesource.com/src/+/2352ce3c43bb9385471953876735e3106d3cf48a
Patch Set 1 #Patch Set 2 : actually remove the file #Patch Set 3 : rebase #Patch Set 4 : rebase #Messages
Total messages: 24 (19 generated)
The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_libfuzzer_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/bui...)
The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
kwiberg@webrtc.org changed reviewers: + mbonadei@webrtc.org, nisse@webrtc.org
To be landed ~two weeks after the first CL.
Oh, and this version of the CL doesn't actually remove the .h file, so as to not confuse the Chromium FYI bots. When I land this, I'll actually remove the file.
Patchset #1 (id:1) has been deleted
lgtm. On 2017/08/31 17:39:02, kwiberg-webrtc wrote: > Oh, and this version of the CL doesn't actually remove the .h file, so as to not > confuse the Chromium FYI bots. When I land this, I'll actually remove the file. Oh, I've never thought at this trick to run chromium trybots. Nice!
Description was changed from ========== Remove backwards compatibilty header for ArrayView BUG=none ========== to ========== Remove backwards compatibilty header for ArrayView BUG=webrtc:8205 ==========
The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kwiberg@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from mbonadei@webrtc.org Link to the patchset: https://codereview.webrtc.org/3010633002/#ps80001 (title: "rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1505728387394670,
"parent_rev": "ef6ee9850bb9d0c1a1dff5f116080e8f04ffff13", "commit_rev":
"2352ce3c43bb9385471953876735e3106d3cf48a"}
Message was sent while issue was closed.
Description was changed from ========== Remove backwards compatibilty header for ArrayView BUG=webrtc:8205 ========== to ========== Remove backwards compatibilty header for ArrayView BUG=webrtc:8205 Review-Url: https://codereview.webrtc.org/3010633002 Cr-Commit-Position: refs/heads/master@{#19884} Committed: https://webrtc.googlesource.com/src/+/2352ce3c43bb9385471953876735e3106d3cf48a ==========
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as https://webrtc.googlesource.com/src/+/2352ce3c43bb9385471953876735e3106d3cf48a |
