Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 3010623002: Change capture time format to nanoseconds in EncodedImage. (Closed)

Created:
3 years, 3 months ago by sakal
Modified:
3 years, 3 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Change capture time format to nanoseconds in EncodedImage. The millisecond field is deprecated and will be removed once the dependencies have been updated. BUG=webrtc:7760 Review-Url: https://codereview.webrtc.org/3010623002 Cr-Commit-Position: refs/heads/master@{#19622} Committed: https://chromium.googlesource.com/external/webrtc/+/e172d89f73775d81fa72d8aa18604fec30ce60d9

Patch Set 1 : Add missing changes. #

Patch Set 2 : Update decoder wrapper. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -41 lines) Patch
M webrtc/sdk/android/api/org/webrtc/EncodedImage.java View 5 chunks +15 lines, -6 lines 0 comments Download
M webrtc/sdk/android/instrumentationtests/src/org/webrtc/HardwareVideoEncoderTest.java View 6 chunks +6 lines, -6 lines 0 comments Download
M webrtc/sdk/android/src/java/org/webrtc/HardwareVideoDecoder.java View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/sdk/android/src/java/org/webrtc/HardwareVideoEncoder.java View 10 chunks +18 lines, -17 lines 0 comments Download
M webrtc/sdk/android/src/jni/videodecoderwrapper.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/sdk/android/src/jni/videodecoderwrapper.cc View 1 5 chunks +10 lines, -9 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (12 generated)
sakal
PTAL
3 years, 3 months ago (2017-08-29 12:00:27 UTC) #5
magjed_webrtc
lgtm
3 years, 3 months ago (2017-08-30 09:40:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3010623002/40001
3 years, 3 months ago (2017-08-31 09:35:15 UTC) #13
commit-bot: I haz the power
3 years, 3 months ago (2017-08-31 09:37:35 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/e172d89f73775d81fa72d8aa1...

Powered by Google App Engine
This is Rietveld 408576698