Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 3010343002: Break the ANA build-target into ANA and ANA-config (Closed)

Created:
3 years, 3 months ago by eladalon
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Break the ANA build-target into ANA and ANA-config This is done to solve a dependency-cycle with the RtcEventLog - now the RtcEventLog can depend on the config part of ANA, and be able to peer inside, while the implementation part of ANA can invoke the RtcEventLog. BUG=webrtc:8111 TBR=stefan@webrtc.org Review-Url: https://codereview.webrtc.org/3010343002 Cr-Commit-Position: refs/heads/master@{#19793} Committed: https://chromium.googlesource.com/external/webrtc/+/1e7dd31001cfa13b066e27352a24947c5ff95c31

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -77 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 2 chunks +14 lines, -1 line 0 comments Download
D webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor.cc View 1 chunk +0 lines, -22 lines 0 comments Download
A + webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_config.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/include/audio_network_adaptor.h View 1 chunk +1 line, -18 lines 0 comments Download
A + webrtc/modules/audio_coding/audio_network_adaptor/include/audio_network_adaptor_config.h View 3 chunks +4 lines, -35 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
eladalon
PTAL
3 years, 3 months ago (2017-09-12 09:36:28 UTC) #2
terelius
lgtm
3 years, 3 months ago (2017-09-12 09:59:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3010343002/1
3 years, 3 months ago (2017-09-12 10:47:33 UTC) #5
commit-bot: I haz the power
3 years, 3 months ago (2017-09-12 11:38:32 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/1e7dd31001cfa13b066e27352...

Powered by Google App Engine
This is Rietveld 408576698