Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 3010293002: Fixing path to the protobuf_utils.h file. (Closed)

Created:
3 years, 3 months ago by mbonadei
Modified:
3 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing path to the protobuf_utils.h file. This path is wrong and it generates a bad error message because the only file that can use google::protobuf is now under rtc_base and not under base. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/3010293002 Cr-Commit-Position: refs/heads/master@{#19750} Committed: https://chromium.googlesource.com/external/webrtc/+/01410dcc99a2dfb9d0d29fad13507cdd08ee71c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
mbonadei
3 years, 3 months ago (2017-09-08 14:51:17 UTC) #3
kjellander_webrtc
lgtm
3 years, 3 months ago (2017-09-08 14:52:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3010293002/1
3 years, 3 months ago (2017-09-08 14:58:51 UTC) #6
commit-bot: I haz the power
3 years, 3 months ago (2017-09-08 15:02:00 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/01410dcc99a2dfb9d0d29fad1...

Powered by Google App Engine
This is Rietveld 408576698