Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 3010233002: Remove static/default interface method usage. (Closed)

Created:
3 years, 3 months ago by sakal
Modified:
3 years, 3 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove static/default interface method usage. BUG=webrtc:8217 Review-Url: https://codereview.webrtc.org/3010233002 Cr-Commit-Position: refs/heads/master@{#19741} Committed: https://chromium.googlesource.com/external/webrtc/+/9bc599f6da435acba6fbb2e5e8b43863dcc45c2b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -54 lines) Patch
M webrtc/sdk/android/api/org/webrtc/EglBase.java View 2 chunks +15 lines, -16 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/EglRenderer.java View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/RendererCommon.java View 2 chunks +27 lines, -30 lines 0 comments Download
M webrtc/sdk/android/src/java/org/webrtc/EglBase10.java View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/sdk/android/src/java/org/webrtc/EglBase14.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
sakal
PTAL
3 years, 3 months ago (2017-09-07 15:11:42 UTC) #2
magjed_webrtc
lgtm
3 years, 3 months ago (2017-09-08 11:18:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3010233002/1
3 years, 3 months ago (2017-09-08 11:18:12 UTC) #5
commit-bot: I haz the power
3 years, 3 months ago (2017-09-08 11:46:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/9bc599f6da435acba6fbb2e5e...

Powered by Google App Engine
This is Rietveld 408576698