Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 3010133002: Tightening visibility and removing a public_dep. (Closed)

Created:
3 years, 3 months ago by mbonadei
Modified:
3 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Tightening visibility and removing a public_dep. This CL aligns the visibility and the dependency between the _objc and the _generic targets to the standard decided in: https://codereview.webrtc.org/3001623003. BUG=webrtc:7743 Review-Url: https://codereview.webrtc.org/3010133002 Cr-Commit-Position: refs/heads/master@{#19687} Committed: https://chromium.googlesource.com/external/webrtc/+/9c296b3490a40491455061209fdf409ce5214b19

Patch Set 1 #

Patch Set 2 : Fixing public_deps append #

Patch Set 3 : Fixing rtc_test target #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -21 lines) Patch
M webrtc/test/BUILD.gn View 1 2 8 chunks +22 lines, -21 lines 0 comments Download
M webrtc/video/BUILD.gn View 1 2 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
mbonadei
3 years, 3 months ago (2017-09-04 11:44:42 UTC) #2
kjellander_webrtc
lgtm
3 years, 3 months ago (2017-09-04 11:51:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3010133002/40001
3 years, 3 months ago (2017-09-05 11:43:09 UTC) #8
commit-bot: I haz the power
3 years, 3 months ago (2017-09-05 12:11:47 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/9c296b3490a40491455061209...

Powered by Google App Engine
This is Rietveld 408576698