Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Issue 3010003002: Set protected_by_flexfec flag properly in tests. (Closed)

Created:
3 years, 3 months ago by brandtr
Modified:
3 years, 3 months ago
Reviewers:
philipel, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Set protected_by_flexfec flag properly in tests. BUG=none Review-Url: https://codereview.webrtc.org/3010003002 Cr-Commit-Position: refs/heads/master@{#19921} Committed: https://webrtc.googlesource.com/src/+/7cd28b91721f17d91acde534605af4802320bff0

Patch Set 1 #

Patch Set 2 : newline #

Patch Set 3 : Rebase. #

Patch Set 4 : Rebase. #

Patch Set 5 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M media/engine/webrtcvideoengine_unittest.cc View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
M test/call_test.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M video/video_quality_test.cc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
brandtr
3 years, 3 months ago (2017-09-01 13:09:44 UTC) #2
philipel
lgtm
3 years, 3 months ago (2017-09-01 13:20:56 UTC) #3
brandtr
On 2017/09/01 13:20:56, philipel wrote: > lgtm Verified in video_loopback, video_engine_tests, and webrtc_perf_tests.
3 years, 3 months ago (2017-09-01 13:25:37 UTC) #4
brandtr
Rebase.
3 years, 3 months ago (2017-09-08 07:03:45 UTC) #9
brandtr
Rebase.
3 years, 3 months ago (2017-09-11 14:22:40 UTC) #10
brandtr
Rebase.
3 years, 3 months ago (2017-09-21 08:55:33 UTC) #11
brandtr
ping: trying to land this before infra changes.
3 years, 3 months ago (2017-09-22 06:37:51 UTC) #12
stefan-webrtc
lgtm
3 years, 3 months ago (2017-09-22 06:55:22 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3010003002/80001
3 years, 3 months ago (2017-09-22 06:55:32 UTC) #16
commit-bot: I haz the power
3 years, 3 months ago (2017-09-22 07:26:32 UTC) #19
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://webrtc.googlesource.com/src/+/7cd28b91721f17d91acde534605af4802320bff0

Powered by Google App Engine
This is Rietveld 408576698