Avoid calling RtpFrameObject::GetCodecHeader twice in the RtpFrameReferenceFinder.

Avoid calling RtpFrameObject::GetCodecHeader twice in the RtpFrameReferenceFinder.

This is good for a few reasons:
 - We avoid grabing a lock twice.
 - We avoid an unnecessary copy.
 - We avoid a race where a packet could potentially be removed before the
   second time we call GetCodecHeader.

BUG=None

Review-Url: https://codereview.webrtc.org/3009833002
Cr-Commit-Position: refs/heads/master@{#19635}
Committed: https://chromium.googlesource.com/external/webrtc/+/4c14009e83bd147b440a785d7fb492da3355576c

[philipel, 2017-08-30 08:54:37]

philipel@webrtc.org changed reviewers:
+ danilchap@webrtc.org

[philipel, 2017-08-30 08:54:38]

PTAL

https://codereview.webrtc.org/3009833002/diff/1/webrtc/modules/video_coding/r...
File webrtc/modules/video_coding/rtp_frame_reference_finder.cc (right):

https://codereview.webrtc.org/3009833002/diff/1/webrtc/modules/video_coding/r...
webrtc/modules/video_coding/rtp_frame_reference_finder.cc:395: if
(!rtp_codec_header)
I thought I had made this change at some earlier point, but piggybacked it on
this CL.

[danilchap, 2017-08-30 10:21:09]

lgtm

[philipel, 2017-08-30 10:36:53]

The CQ bit was checked by philipel@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-30 10:36:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-30 11:06:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-30 11:06:10]

Dry run: This issue passed the CQ dry run.

[philipel, 2017-08-30 11:17:33]

philipel@webrtc.org changed reviewers:
+ sprang@webrtc.org

[philipel, 2017-08-30 11:17:34]

Erik, RS please :)

[sprang_webrtc, 2017-08-31 12:11:50]

lgtm

[philipel, 2017-08-31 15:07:30]

The CQ bit was checked by philipel@webrtc.org

[commit-bot: I haz the power, 2017-08-31 15:07:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-31 15:31:46]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1504192050461520, "parent_rev":
"85d7650ab6a84477e807d458ea835154cf5138da", "commit_rev":
"4c14009e83bd147b440a785d7fb492da3355576c"}

[commit-bot: I haz the power, 2017-08-31 15:31:51]

Description was changed from

==========
Avoid calling RtpFrameObject::GetCodecHeader twice in the
RtpFrameReferenceFinder.

This is good for a few reasons:
 - We avoid grabing a lock twice.
 - We avoid an unnecessary copy.
 - We avoid a race where a packet could potentially be removed before the
   second time we call GetCodecHeader.

BUG=None
==========

to

==========
Avoid calling RtpFrameObject::GetCodecHeader twice in the
RtpFrameReferenceFinder.

This is good for a few reasons:
 - We avoid grabing a lock twice.
 - We avoid an unnecessary copy.
 - We avoid a race where a packet could potentially be removed before the
   second time we call GetCodecHeader.

BUG=None

Review-Url: https://codereview.webrtc.org/3009833002
Cr-Commit-Position: refs/heads/master@{#19635}
Committed:
https://chromium.googlesource.com/external/webrtc/+/4c14009e83bd147b440a785d7...
==========

[commit-bot: I haz the power, 2017-08-31 15:31:52]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/4c14009e83bd147b440a785d7...