Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 3009823002: Add visualization of late feedback packets, and avoid plotting incorrect delays computed based on t… (Closed)

Created:
3 years, 3 months ago by stefan-webrtc
Modified:
3 years, 3 months ago
Reviewers:
terelius
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add visualization of late feedback packets, and avoid plotting incorrect delays computed based on those. BUG=None Review-Url: https://codereview.webrtc.org/3009823002 Cr-Commit-Position: refs/heads/master@{#19705} Committed: https://chromium.googlesource.com/external/webrtc/+/a0a8ed78c3f89751d1589c1d66ad61d2b9f7e562

Patch Set 1 #

Total comments: 4

Patch Set 2 : Comment addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M webrtc/rtc_tools/event_log_visualizer/analyzer.cc View 1 4 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
stefan-webrtc
3 years, 3 months ago (2017-08-30 07:24:45 UTC) #2
terelius
lgtm https://codereview.webrtc.org/3009823002/diff/1/webrtc/rtc_tools/event_log_visualizer/analyzer.cc File webrtc/rtc_tools/event_log_visualizer/analyzer.cc (right): https://codereview.webrtc.org/3009823002/diff/1/webrtc/rtc_tools/event_log_visualizer/analyzer.cc#newcode1318 webrtc/rtc_tools/event_log_visualizer/analyzer.cc:1318: point.y -= estimated_base_delay_ms; FYI: This can cause negative ...
3 years, 3 months ago (2017-08-30 11:11:25 UTC) #3
stefan-webrtc
Comment addressed.
3 years, 3 months ago (2017-09-01 08:52:58 UTC) #4
stefan-webrtc
https://codereview.webrtc.org/3009823002/diff/1/webrtc/rtc_tools/event_log_visualizer/analyzer.cc File webrtc/rtc_tools/event_log_visualizer/analyzer.cc (right): https://codereview.webrtc.org/3009823002/diff/1/webrtc/rtc_tools/event_log_visualizer/analyzer.cc#newcode1318 webrtc/rtc_tools/event_log_visualizer/analyzer.cc:1318: point.y -= estimated_base_delay_ms; On 2017/08/30 11:11:25, terelius wrote: > ...
3 years, 3 months ago (2017-09-01 08:53:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3009823002/20001
3 years, 3 months ago (2017-09-01 08:54:16 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_ubsan_vptr on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds/15821)
3 years, 3 months ago (2017-09-01 09:17:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3009823002/20001
3 years, 3 months ago (2017-09-06 08:41:19 UTC) #12
commit-bot: I haz the power
3 years, 3 months ago (2017-09-06 09:06:46 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/a0a8ed78c3f89751d1589c1d6...

Powered by Google App Engine
This is Rietveld 408576698