Add visualization of late feedback packets, and avoid plotting incorrect delays computed based on t…

Add visualization of late feedback packets, and avoid plotting incorrect delays computed based on those.

BUG=None

Review-Url: https://codereview.webrtc.org/3009823002
Cr-Commit-Position: refs/heads/master@{#19705}
Committed: https://chromium.googlesource.com/external/webrtc/+/a0a8ed78c3f89751d1589c1d66ad61d2b9f7e562

[stefan-webrtc, 2017-08-30 07:24:44]

stefan@webrtc.org changed reviewers:
+ terelius@webrtc.org

[terelius, 2017-08-30 11:11:25]

lgtm

https://codereview.webrtc.org/3009823002/diff/1/webrtc/rtc_tools/event_log_vi...
File webrtc/rtc_tools/event_log_visualizer/analyzer.cc (right):

https://codereview.webrtc.org/3009823002/diff/1/webrtc/rtc_tools/event_log_vi...
webrtc/rtc_tools/event_log_visualizer/analyzer.cc:1318: point.y -=
estimated_base_delay_ms;
FYI: This can cause negative values if the first packet is late.

https://codereview.webrtc.org/3009823002/diff/1/webrtc/rtc_tools/event_log_vi...
webrtc/rtc_tools/event_log_visualizer/analyzer.cc:1321:
plot->AppendTimeSeries(std::move(late_feedback_series));
I prefer AppendTimeSeriesIfNotEmpty here.

[stefan-webrtc, 2017-09-01 08:52:58]

Comment addressed.

[stefan-webrtc, 2017-09-01 08:53:07]

https://codereview.webrtc.org/3009823002/diff/1/webrtc/rtc_tools/event_log_vi...
File webrtc/rtc_tools/event_log_visualizer/analyzer.cc (right):

https://codereview.webrtc.org/3009823002/diff/1/webrtc/rtc_tools/event_log_vi...
webrtc/rtc_tools/event_log_visualizer/analyzer.cc:1318: point.y -=
estimated_base_delay_ms;
On 2017/08/30 11:11:25, terelius wrote:
> FYI: This can cause negative values if the first packet is late.

Acknowledged.

https://codereview.webrtc.org/3009823002/diff/1/webrtc/rtc_tools/event_log_vi...
webrtc/rtc_tools/event_log_visualizer/analyzer.cc:1321:
plot->AppendTimeSeries(std::move(late_feedback_series));
On 2017/08/30 11:11:25, terelius wrote:
> I prefer AppendTimeSeriesIfNotEmpty here.

Done.

[stefan-webrtc, 2017-09-01 08:54:12]

The CQ bit was checked by stefan@webrtc.org

[stefan-webrtc, 2017-09-01 08:54:12]

The patchset sent to the CQ was uploaded after l-g-t-m from terelius@webrtc.org
Link to the patchset: https://codereview.webrtc.org/3009823002/#ps20001 (title:
"Comment addressed.")

[commit-bot: I haz the power, 2017-09-01 08:54:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-01 09:17:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-01 09:17:47]

Try jobs failed on following builders:
  linux_ubsan_vptr on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds...)

[stefan-webrtc, 2017-09-06 08:41:09]

The CQ bit was checked by stefan@webrtc.org

[commit-bot: I haz the power, 2017-09-06 08:41:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-06 09:06:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1504687269797140,
"parent_rev": "ee3d760e45d7aaeb9c97522878b9ac891f423d22", "commit_rev":
"a0a8ed78c3f89751d1589c1d66ad61d2b9f7e562"}

[commit-bot: I haz the power, 2017-09-06 09:06:45]

Description was changed from

==========
Add visualization of late feedback packets, and avoid plotting incorrect delays
computed based on those.

BUG=None
==========

to

==========
Add visualization of late feedback packets, and avoid plotting incorrect delays
computed based on those.

BUG=None

Review-Url: https://codereview.webrtc.org/3009823002
Cr-Commit-Position: refs/heads/master@{#19705}
Committed:
https://chromium.googlesource.com/external/webrtc/+/a0a8ed78c3f89751d1589c1d6...
==========

[commit-bot: I haz the power, 2017-09-06 09:06:46]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/a0a8ed78c3f89751d1589c1d6...