Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Issue 3009673002: Move GetOutstandingBytes() call inside field trial check to avoid taking an unneccessary lock. (Closed)

Created:
3 years, 3 months ago by stefan-webrtc
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move GetOutstandingBytes() call inside field trial check to avoid taking an unneccessary lock. BUG=webrtc:7926 Review-Url: https://codereview.webrtc.org/3009673002 Cr-Commit-Position: refs/heads/master@{#19540} Committed: https://chromium.googlesource.com/external/webrtc/+/a86f57e624100e8ca227fee8b726a59f3440f92f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -24 lines) Patch
M webrtc/modules/congestion_controller/send_side_congestion_controller.cc View 2 chunks +23 lines, -24 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
stefan-webrtc
3 years, 3 months ago (2017-08-26 13:02:48 UTC) #3
danilchap
lgtm
3 years, 3 months ago (2017-08-26 13:05:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3009673002/1
3 years, 3 months ago (2017-08-26 13:31:42 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/a86f57e624100e8ca227fee8b726a59f3440f92f
3 years, 3 months ago (2017-08-26 13:33:50 UTC) #12
chrisbendeler
lgtm
3 years, 3 months ago (2017-08-27 08:25:56 UTC) #14
chrisbendeler
lgtm lgtm
3 years, 3 months ago (2017-08-27 08:25:58 UTC) #15
chrisbendeler
3 years, 3 months ago (2017-08-27 08:25:59 UTC) #16
Message was sent while issue was closed.
lgtm

lgtm

Powered by Google App Engine
This is Rietveld 408576698