Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 3009613002: Android: Replace webrtc_jni namespace with nested jni namespace (Closed)

Created:
3 years, 3 months ago by magjed_webrtc
Modified:
3 years, 3 months ago
Reviewers:
brandtr, sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android: Replace webrtc_jni namespace with nested jni namespace This CL replaces: namespace webrtc_jni { with: namespace webrtc { namespace jni { The main benefit is that we don't have to use the webrtc:: qualifier inside the jni namespace so we can reduce some clutter. BUG=None Review-Url: https://codereview.webrtc.org/3009613002 Cr-Commit-Position: refs/heads/master@{#19569} Committed: https://chromium.googlesource.com/external/webrtc/+/a3d4f68fb49decd3a365e9a60c9d530c691d6b73

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+855 lines, -773 lines) Patch
M webrtc/examples/unityplugin/classreferenceholder.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/examples/unityplugin/classreferenceholder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/examples/unityplugin/jni_onload.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/examples/unityplugin/simple_peer_connection.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/android_test_initializer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/sdk/android/src/jni/androidhistogram_jni.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M webrtc/sdk/android/src/jni/androidmediacodeccommon.h View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/sdk/android/src/jni/androidmediadecoder_jni.h View 2 chunks +7 lines, -6 lines 0 comments Download
M webrtc/sdk/android/src/jni/androidmediadecoder_jni.cc View 13 chunks +15 lines, -26 lines 0 comments Download
M webrtc/sdk/android/src/jni/androidmediaencoder_jni.h View 3 chunks +6 lines, -5 lines 0 comments Download
M webrtc/sdk/android/src/jni/androidmediaencoder_jni.cc View 34 chunks +85 lines, -103 lines 0 comments Download
M webrtc/sdk/android/src/jni/androidmetrics_jni.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M webrtc/sdk/android/src/jni/androidvideotracksource.h View 4 chunks +6 lines, -5 lines 0 comments Download
M webrtc/sdk/android/src/jni/androidvideotracksource.cc View 6 chunks +12 lines, -12 lines 0 comments Download
M webrtc/sdk/android/src/jni/androidvideotracksource_jni.cc View 7 chunks +23 lines, -18 lines 0 comments Download
M webrtc/sdk/android/src/jni/classreferenceholder.h View 2 chunks +11 lines, -1 line 0 comments Download
M webrtc/sdk/android/src/jni/classreferenceholder.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/sdk/android/src/jni/filevideocapturer_jni.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/sdk/android/src/jni/jni_helpers.h View 2 chunks +11 lines, -1 line 0 comments Download
M webrtc/sdk/android/src/jni/jni_helpers.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/sdk/android/src/jni/jni_onload.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/sdk/android/src/jni/native_handle_impl.h View 7 chunks +12 lines, -10 lines 0 comments Download
M webrtc/sdk/android/src/jni/native_handle_impl.cc View 15 chunks +31 lines, -32 lines 0 comments Download
M webrtc/sdk/android/src/jni/nv12buffer_jni.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/sdk/android/src/jni/nv21buffer_jni.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/androidnetworkmonitor_jni.h View 2 chunks +11 lines, -1 line 0 comments Download
M webrtc/sdk/android/src/jni/pc/androidnetworkmonitor_jni.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/audio_jni.h View 1 chunk +6 lines, -4 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/audio_jni.cc View 1 chunk +8 lines, -6 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/audiotrack_jni.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/callsessionfilerotatinglogsink_jni.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/datachannel_jni.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/datachannelobserver_jni.h View 2 chunks +6 lines, -4 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/datachannelobserver_jni.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/dtmfsender_jni.cc View 1 5 chunks +10 lines, -8 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/java_native_conversion.h View 2 chunks +27 lines, -28 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/java_native_conversion.cc View 20 chunks +61 lines, -60 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/logging_jni.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/media_jni.h View 1 chunk +10 lines, -10 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/media_jni.cc View 1 chunk +11 lines, -11 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/mediaconstraints_jni.h View 2 chunks +5 lines, -3 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/mediaconstraints_jni.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/mediasource_jni.cc View 1 1 chunk +6 lines, -4 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/mediastream_jni.cc View 6 chunks +14 lines, -12 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/mediastreamtrack_jni.cc View 1 6 chunks +9 lines, -7 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/null_audio_jni.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/null_media_jni.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/null_video_jni.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/ownedfactoryandthreads.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/ownedfactoryandthreads.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/peerconnection_jni.cc View 1 15 chunks +24 lines, -23 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/peerconnectionfactory_jni.cc View 16 chunks +33 lines, -33 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/peerconnectionobserver_jni.h View 3 chunks +19 lines, -24 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/peerconnectionobserver_jni.cc View 12 chunks +15 lines, -15 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/rtcstatscollectorcallbackwrapper.h View 2 chunks +10 lines, -11 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/rtcstatscollectorcallbackwrapper.cc View 12 chunks +41 lines, -41 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/rtpreceiver_jni.cc View 1 8 chunks +12 lines, -11 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/rtpreceiverobserver_jni.h View 2 chunks +5 lines, -3 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/rtpreceiverobserver_jni.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/rtpsender_jni.cc View 1 7 chunks +13 lines, -13 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/sdpobserver_jni.h View 5 chunks +7 lines, -6 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/statsobserver_jni.h View 2 chunks +9 lines, -8 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/statsobserver_jni.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/video_jni.h View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/video_jni.cc View 4 chunks +12 lines, -11 lines 0 comments Download
M webrtc/sdk/android/src/jni/surfacetexturehelper_jni.h View 3 chunks +6 lines, -4 lines 0 comments Download
M webrtc/sdk/android/src/jni/surfacetexturehelper_jni.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M webrtc/sdk/android/src/jni/video_renderer_jni.cc View 6 chunks +13 lines, -12 lines 0 comments Download
M webrtc/sdk/android/src/jni/videodecoderfactorywrapper.h View 2 chunks +6 lines, -5 lines 0 comments Download
M webrtc/sdk/android/src/jni/videodecoderfactorywrapper.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M webrtc/sdk/android/src/jni/videodecoderwrapper.h View 3 chunks +16 lines, -15 lines 0 comments Download
M webrtc/sdk/android/src/jni/videodecoderwrapper.cc View 8 chunks +21 lines, -22 lines 0 comments Download
M webrtc/sdk/android/src/jni/videofilerenderer_jni.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/sdk/android/src/jni/videoframe_jni.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/sdk/android/src/jni/videotrack_jni.cc View 5 chunks +13 lines, -14 lines 0 comments Download
M webrtc/sdk/android/src/jni/wrapped_native_i420_buffer.h View 1 chunk +5 lines, -3 lines 0 comments Download
M webrtc/sdk/android/src/jni/wrapped_native_i420_buffer.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 41 (31 generated)
magjed_webrtc
Sami - please take a look.
3 years, 3 months ago (2017-08-27 20:43:41 UTC) #23
sakal
lgtm
3 years, 3 months ago (2017-08-28 08:09:45 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3009613002/80001
3 years, 3 months ago (2017-08-28 11:51:18 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/20811)
3 years, 3 months ago (2017-08-28 11:55:18 UTC) #28
magjed_webrtc
Rasmus - please review webrtc/modules/video_coding/codecs/test/.
3 years, 3 months ago (2017-08-28 15:05:56 UTC) #30
brandtr
webrtc/modules/video_coding/codecs/test/ lgtm
3 years, 3 months ago (2017-08-28 15:10:59 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3009613002/80001
3 years, 3 months ago (2017-08-28 15:30:01 UTC) #33
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/20834)
3 years, 3 months ago (2017-08-28 15:34:10 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3009613002/100001
3 years, 3 months ago (2017-08-28 22:28:21 UTC) #38
commit-bot: I haz the power
3 years, 3 months ago (2017-08-28 23:24:15 UTC) #41
Message was sent while issue was closed.
Committed patchset #2 (id:100001) as
https://chromium.googlesource.com/external/webrtc/+/a3d4f68fb49decd3a365e9a60...

Powered by Google App Engine
This is Rietveld 408576698