Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 3009363002: Only use BBRs pacer if the unit test is running BBR. (Closed)

Created:
3 years, 3 months ago by terelius
Modified:
3 years, 3 months ago
Reviewers:
philipel
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Only use BBRs pacer if the unit test is running BBR. Otherwise use WebRTCs default pacer. BUG=None Review-Url: https://codereview.webrtc.org/3009363002 Cr-Commit-Position: refs/heads/master@{#19797} Committed: https://chromium.googlesource.com/external/webrtc/+/661d94996b0301cee460d0e486e8371a05977aca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M webrtc/modules/remote_bitrate_estimator/test/packet_sender.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
terelius
PTAL
3 years, 3 months ago (2017-09-12 12:09:49 UTC) #2
philipel
lgtm
3 years, 3 months ago (2017-09-12 12:12:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3009363002/1
3 years, 3 months ago (2017-09-12 12:44:53 UTC) #9
commit-bot: I haz the power
3 years, 3 months ago (2017-09-12 12:47:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/661d94996b0301cee460d0e48...

Powered by Google App Engine
This is Rietveld 408576698