Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1119)

Issue 3009293002: ObjC EncodedImage: Use fixed width integer types (Closed)

Created:
3 years, 3 months ago by magjed_webrtc
Modified:
3 years, 3 months ago
Reviewers:
kthelgason
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

ObjC EncodedImage: Use fixed width integer types We currently use long for some variables, which causes warnings when converting from int64_t. We should use fixed width integer types instead. BUG=b/65491700 Review-Url: https://codereview.webrtc.org/3009293002 Cr-Commit-Position: refs/heads/master@{#19791} Committed: https://chromium.googlesource.com/external/webrtc/+/43467b09c88533d7ecf2659bb7cd66ed423c7f7c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCEncodedImage.mm View 3 chunks +8 lines, -6 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodec.h View 2 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
magjed_webrtc
Kári - please take a look.
3 years, 3 months ago (2017-09-11 14:14:12 UTC) #4
kthelgason
lgtm!
3 years, 3 months ago (2017-09-12 07:22:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3009293002/1
3 years, 3 months ago (2017-09-12 09:27:23 UTC) #9
commit-bot: I haz the power
3 years, 3 months ago (2017-09-12 09:29:55 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/43467b09c88533d7ecf2659bb...

Powered by Google App Engine
This is Rietveld 408576698