Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 3009203002: Make it possible to isolate isac_fix_test. (Closed)

Created:
3 years, 3 months ago by ehmaldonado_webrtc
Modified:
3 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make it possible to isolate isac_fix_test. Successful swarming run: https://chromium-swarm.appspot.com/task?id=38769e8dd5d3e110&refresh=10&show_raw=1 BUG=chromium:755660 NOTRY=True Review-Url: https://codereview.webrtc.org/3009203002 Cr-Commit-Position: refs/heads/master@{#19738} Committed: https://chromium.googlesource.com/external/webrtc/+/25586cefddcc4b38a5260ef1c6b8cc72b9c1893e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M tools_webrtc/mb/gn_isolate_map.pyl View 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
ehmaldonado_webrtc
PTAL
3 years, 3 months ago (2017-09-07 19:28:41 UTC) #3
kjellander_webrtc
Nice! Please use NOTRY=True lgtm
3 years, 3 months ago (2017-09-08 04:30:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3009203002/1
3 years, 3 months ago (2017-09-08 06:15:32 UTC) #7
commit-bot: I haz the power
3 years, 3 months ago (2017-09-08 06:18:47 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/25586cefddcc4b38a5260ef1c...

Powered by Google App Engine
This is Rietveld 408576698