Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1066)

Issue 3009093002: Fixes issue in ADM on Mac OSX when audio is renegotiated

Created:
3 years, 3 months ago by henrika_webrtc
Modified:
3 years, 2 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixes issue in ADM on Mac OSX when audio is renegotiated BUG=webrtc:8041 NOTRY=TRUE

Patch Set 1 #

Patch Set 2 : removed comments #

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -13 lines) Patch
M webrtc/modules/audio_device/audio_device_unittest.cc View 1 1 chunk +46 lines, -0 lines 0 comments Download
M webrtc/modules/audio_device/mac/audio_device_mac.cc View 1 2 13 chunks +31 lines, -13 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
henrika_webrtc
PTAL
3 years, 3 months ago (2017-09-13 07:07:09 UTC) #7
hlundin-webrtc
RS-LGTM
3 years, 3 months ago (2017-09-14 13:47:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3009093002/40001
3 years, 3 months ago (2017-09-14 13:49:30 UTC) #10
commit-bot: I haz the power
Failed to commit the patch.
3 years, 3 months ago (2017-09-14 15:29:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3009093002/40001
3 years, 3 months ago (2017-09-15 07:53:42 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/21677)
3 years, 3 months ago (2017-09-15 07:58:22 UTC) #20
henrika_webrtc
3 years, 2 months ago (2017-09-25 14:35:41 UTC) #21

Powered by Google App Engine
This is Rietveld 408576698