Make PeerConnectionClient non-singleton.

Make PeerConnectionClient non-singleton.

Ownership of EglBase is moved to PeerConnectionClient.

BUG=webrtc:8135
Review-Url: https://codereview.webrtc.org/3007893002
Cr-Commit-Position: refs/heads/master@{#19634}
Committed: https://chromium.googlesource.com/external/webrtc/+/85d7650ab6a84477e807d458ea835154cf5138da

[sakal, 2017-08-31 09:12:42]

Patchset #1 (id:1) has been deleted

[sakal, 2017-08-31 09:14:28]

sakal@webrtc.org changed reviewers:
+ magjed@webrtc.org

[sakal, 2017-08-31 09:14:29]

PTAL

[magjed_webrtc, 2017-08-31 11:28:59]

https://codereview.webrtc.org/3007893002/diff/20001/webrtc/examples/androidap...
File webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java
(right):

https://codereview.webrtc.org/3007893002/diff/20001/webrtc/examples/androidap...
webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java:108:
// created on the same thread as previously destroyed factory.
Do we need this to avoid the crash in issue 8135? Isn't PeerConnectionFactory
.dispose() synchronous?

[sakal, 2017-08-31 14:18:55]

https://codereview.webrtc.org/3007893002/diff/20001/webrtc/examples/androidap...
File webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java
(right):

https://codereview.webrtc.org/3007893002/diff/20001/webrtc/examples/androidap...
webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java:108:
// created on the same thread as previously destroyed factory.
On 2017/08/31 11:28:59, magjed_webrtc wrote:
> Do we need this to avoid the crash in issue 8135? Isn't PeerConnectionFactory
> .dispose() synchronous?

This is needed because close in asynchronous.

[magjed_webrtc, 2017-08-31 14:35:50]

lgtm

[sakal, 2017-08-31 14:36:26]

The CQ bit was checked by sakal@webrtc.org

[commit-bot: I haz the power, 2017-08-31 14:36:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-31 15:03:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1504190186463180,
"parent_rev": "da194e79c4a86869e8afccf9827c716f0b073fb1", "commit_rev":
"85d7650ab6a84477e807d458ea835154cf5138da"}

[commit-bot: I haz the power, 2017-08-31 15:03:53]

Description was changed from

==========
Make PeerConnectionClient non-singleton.

Ownership of EglBase is moved to PeerConnectionClient.

BUG=webrtc:8135
==========

to

==========
Make PeerConnectionClient non-singleton.

Ownership of EglBase is moved to PeerConnectionClient.

BUG=webrtc:8135

Review-Url: https://codereview.webrtc.org/3007893002
Cr-Commit-Position: refs/heads/master@{#19634}
Committed:
https://chromium.googlesource.com/external/webrtc/+/85d7650ab6a84477e807d458e...
==========

[commit-bot: I haz the power, 2017-08-31 15:03:54]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/85d7650ab6a84477e807d458e...