Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 3007833002: Further utilizing the AEC3 config struct for constants (Closed)

Created:
3 years, 3 months ago by peah-webrtc
Modified:
3 years, 3 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Further utilizing the AEC3 config struct for constants BUG=webrtc:5298 Review-Url: https://codereview.webrtc.org/3007833002 Cr-Commit-Position: refs/heads/master@{#19605} Committed: https://chromium.googlesource.com/external/webrtc/+/4fed3c0b6f74acbdce2f7c7395463772a19dc739

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -40 lines) Patch
M webrtc/modules/audio_processing/aec3/aec_state.cc View 1 chunk +5 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/aec3/block_processor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/echo_path_delay_estimator.h View 3 chunks +4 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/echo_path_delay_estimator.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/echo_path_delay_estimator_unittest.cc View 8 chunks +17 lines, -8 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/matched_filter.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/aec3/matched_filter.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/matched_filter_unittest.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/render_delay_controller.h View 2 chunks +4 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/aec3/render_delay_controller.cc View 4 chunks +12 lines, -5 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/render_delay_controller_unittest.cc View 7 chunks +16 lines, -9 lines 0 comments Download
M webrtc/modules/audio_processing/include/audio_processing.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
peah-webrtc
Hi ivoc@ Could you please take a look at this CL?
3 years, 3 months ago (2017-08-30 09:58:31 UTC) #4
ivoc
lgtm!
3 years, 3 months ago (2017-08-30 11:14:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3007833002/20001
3 years, 3 months ago (2017-08-30 13:12:12 UTC) #7
commit-bot: I haz the power
3 years, 3 months ago (2017-08-30 13:58:51 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/4fed3c0b6f74acbdce2f7c739...

Powered by Google App Engine
This is Rietveld 408576698