Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 3007773002: Increase timeout in RTCUIApplicationStatusObserver (Closed)

Created:
3 years, 3 months ago by andersc
Modified:
3 years, 3 months ago
Reviewers:
kthelgason
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Increase timeout in RTCUIApplicationStatusObserver Increase timeout since the wait function timed out in certain debugging circumstances. Also change the check to a DCHECK since it is not really a critical error if it would time out. BUG=None Review-Url: https://codereview.webrtc.org/3007773002 Cr-Commit-Position: refs/heads/master@{#19582} Committed: https://chromium.googlesource.com/external/webrtc/+/cfab6c7c04e3480c9dba32ca86a33428cea6ea34

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M webrtc/sdk/objc/Framework/Classes/Common/RTCUIApplicationStatusObserver.m View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
andersc
3 years, 3 months ago (2017-08-29 12:41:32 UTC) #2
kthelgason
lgtm
3 years, 3 months ago (2017-08-29 12:43:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3007773002/1
3 years, 3 months ago (2017-08-29 12:43:52 UTC) #5
commit-bot: I haz the power
3 years, 3 months ago (2017-08-29 13:52:16 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/cfab6c7c04e3480c9dba32ca8...

Powered by Google App Engine
This is Rietveld 408576698