Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 3007753002: Verify parsed QP value when frame is encoded instead of storing parsed value and verifying later. (Closed)

Created:
3 years, 3 months ago by åsapersson
Modified:
3 years, 3 months ago
Reviewers:
brandtr
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Verify parsed QP value when frame is encoded instead of storing parsed value and verifying later. Removes: - VideoProcessor: GetQpFromEncoder, GetQpFromBitstream - FrameInfo: qp_encoder, qp_bitstream BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/3007753002 Cr-Commit-Position: refs/heads/master@{#19579} Committed: https://chromium.googlesource.com/external/webrtc/+/a16c70b8ba37b07b6fa82b2a4314f6f608ad079e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -39 lines) Patch
M webrtc/modules/video_coding/codecs/test/videoprocessor.h View 2 chunks +0 lines, -9 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.cc View 4 chunks +18 lines, -20 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
åsapersson
3 years, 3 months ago (2017-08-29 10:01:43 UTC) #3
brandtr
lgtm
3 years, 3 months ago (2017-08-29 11:22:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3007753002/1
3 years, 3 months ago (2017-08-29 12:37:31 UTC) #11
commit-bot: I haz the power
3 years, 3 months ago (2017-08-29 12:39:43 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/a16c70b8ba37b07b6fa82b2a4...

Powered by Google App Engine
This is Rietveld 408576698