Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: webrtc/media/engine/webrtcvideoengine.h

Issue 3007683002: Let VideoEncoderSoftwareFallbackWrapper own the wrapped encoder (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/engine/webrtcvideoengine.h
diff --git a/webrtc/media/engine/webrtcvideoengine.h b/webrtc/media/engine/webrtcvideoengine.h
index caca11c1fffb5a696b302d7130c03daaf8257a17..deb13b1d2c6063dd95bcf166bad8fdf2b89917f7 100644
--- a/webrtc/media/engine/webrtcvideoengine.h
+++ b/webrtc/media/engine/webrtcvideoengine.h
@@ -317,7 +317,7 @@ class WebRtcVideoChannel : public VideoMediaChannel, public webrtc::Transport {
AllocatedEncoder& operator=(AllocatedEncoder&&) = default;
AllocatedEncoder(std::unique_ptr<webrtc::VideoEncoder> encoder,
- std::unique_ptr<webrtc::VideoEncoder> external_encoder,
+ bool is_external,
const cricket::VideoCodec& codec,
bool has_internal_source);
@@ -326,7 +326,7 @@ class WebRtcVideoChannel : public VideoMediaChannel, public webrtc::Transport {
webrtc::VideoEncoder* encoder() { return encoder_.get(); }
// Returns true if the encoder is external.
- bool IsExternal() { return static_cast<bool>(external_encoder_); }
+ bool IsExternal() { return is_external_; }
cricket::VideoCodec codec() { return codec_; }
@@ -337,11 +337,7 @@ class WebRtcVideoChannel : public VideoMediaChannel, public webrtc::Transport {
private:
std::unique_ptr<webrtc::VideoEncoder> encoder_;
- // TODO(magjed): |external_encoder_| is not used except for managing
- // the lifetime when we use VideoEncoderSoftwareFallbackWrapper. Let
- // VideoEncoderSoftwareFallbackWrapper own the external encoder instead
- // and remove this member variable.
- std::unique_ptr<webrtc::VideoEncoder> external_encoder_;
+ bool is_external_;
cricket::VideoCodec codec_;
bool has_internal_source_;
};

Powered by Google App Engine
This is Rietveld 408576698