Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: webrtc/media/engine/videoencodersoftwarefallbackwrapper.h

Issue 3007683002: Let VideoEncoderSoftwareFallbackWrapper own the wrapped encoder (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/engine/videoencodersoftwarefallbackwrapper.h
diff --git a/webrtc/media/engine/videoencodersoftwarefallbackwrapper.h b/webrtc/media/engine/videoencodersoftwarefallbackwrapper.h
index 8061c008c65a7fd6f18f873e9738ee3ee12ea268..8dec2f5448159bc335165ba77243f2191f884182 100644
--- a/webrtc/media/engine/videoencodersoftwarefallbackwrapper.h
+++ b/webrtc/media/engine/videoencodersoftwarefallbackwrapper.h
@@ -25,8 +25,9 @@ namespace webrtc {
// hardware restrictions, such as max resolution.
class VideoEncoderSoftwareFallbackWrapper : public VideoEncoder {
public:
- VideoEncoderSoftwareFallbackWrapper(const cricket::VideoCodec& codec,
- webrtc::VideoEncoder* encoder);
+ VideoEncoderSoftwareFallbackWrapper(
+ const cricket::VideoCodec& codec,
+ std::unique_ptr<webrtc::VideoEncoder> encoder);
int32_t InitEncode(const VideoCodec* codec_settings,
int32_t number_of_cores,
@@ -96,7 +97,7 @@ class VideoEncoderSoftwareFallbackWrapper : public VideoEncoder {
int64_t rtt_;
cricket::VideoCodec codec_;
- webrtc::VideoEncoder* const encoder_;
+ std::unique_ptr<webrtc::VideoEncoder> encoder_;
brandtr 2017/08/29 11:54:27 drive-by question: Does this mean that it's OK to
std::unique_ptr<webrtc::VideoEncoder> fallback_encoder_;
std::string fallback_implementation_name_;
« no previous file with comments | « no previous file | webrtc/media/engine/videoencodersoftwarefallbackwrapper.cc » ('j') | webrtc/media/engine/webrtcvideoengine.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698