Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 3007673002: Now uses builder class for AudioRecord objects from SDK 23 (Closed)

Created:
3 years, 3 months ago by henrika_webrtc
Modified:
3 years, 3 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Now uses builder class for AudioRecord objects from SDK 23. Cleanup CL. Start using new AudioRecord.Builder class for creating AudioRecord Java instances. Exists from API 23. BUG=webrtc:7962 Review-Url: https://codereview.webrtc.org/3007673002 Cr-Commit-Position: refs/heads/master@{#19571} Committed: https://chromium.googlesource.com/external/webrtc/+/d4495312dc7f6b5d5fc1c163026c52d56e6230f9

Patch Set 1 #

Patch Set 2 : Improved comment #

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java View 1 2 2 chunks +26 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
henrika_webrtc
PTAL
3 years, 3 months ago (2017-08-28 12:56:44 UTC) #5
magjed_webrtc
lgtm
3 years, 3 months ago (2017-08-28 16:34:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3007673002/40001
3 years, 3 months ago (2017-08-29 07:22:31 UTC) #12
commit-bot: I haz the power
3 years, 3 months ago (2017-08-29 07:24:39 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/d4495312dc7f6b5d5fc1c1630...

Powered by Google App Engine
This is Rietveld 408576698