Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1816)

Unified Diff: webrtc/sdk/android/api/org/webrtc/PeerConnection.java

Issue 3007543002: Add PeerConnectionObserver#onRemoveTrack to android sdk
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/android/api/org/webrtc/PeerConnection.java
diff --git a/webrtc/sdk/android/api/org/webrtc/PeerConnection.java b/webrtc/sdk/android/api/org/webrtc/PeerConnection.java
index b2155c42e4d0e79561adb746a3ac67a989fbc179..ecc1c8656f2fea0af2ec0ffc688c4556a502a618 100644
--- a/webrtc/sdk/android/api/org/webrtc/PeerConnection.java
+++ b/webrtc/sdk/android/api/org/webrtc/PeerConnection.java
@@ -91,7 +91,13 @@ public class PeerConnection {
* Triggered when a new track is signaled by the remote peer, as a result of
* setRemoteDescription.
*/
- public void onAddTrack(RtpReceiver receiver, MediaStream[] mediaStreams);
Taylor Brandstetter 2017/08/29 19:48:09 It's not safe to change the signature of this; exi
korniltsev 2017/08/30 21:47:47 reverted it back
+ public void onAddTrack(MediaStreamTrack track, MediaStream[] mediaStreams);
+
+ /**
+ * Triggered when a previously added remote track is removed by the remote peer,
+ * as a result of setRemoteDescription.
+ */
+ void onRemoveTrack(MediaStreamTrack track, MediaStream[] mediaStreams);
Taylor Brandstetter 2017/08/29 19:48:09 Should be public. Also, can you give it an empty d
korniltsev 2017/08/30 21:47:47 Done.
}
/** Java version of PeerConnectionInterface.IceServer. */

Powered by Google App Engine
This is Rietveld 408576698