Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: webrtc/sdk/android/api/org/webrtc/PeerConnection.java

Issue 3007543002: Add PeerConnectionObserver#onRemoveTrack to android sdk
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 /** Triggered when a remote peer opens a DataChannel. */ 84 /** Triggered when a remote peer opens a DataChannel. */
85 public void onDataChannel(DataChannel dataChannel); 85 public void onDataChannel(DataChannel dataChannel);
86 86
87 /** Triggered when renegotiation is necessary. */ 87 /** Triggered when renegotiation is necessary. */
88 public void onRenegotiationNeeded(); 88 public void onRenegotiationNeeded();
89 89
90 /** 90 /**
91 * Triggered when a new track is signaled by the remote peer, as a result of 91 * Triggered when a new track is signaled by the remote peer, as a result of
92 * setRemoteDescription. 92 * setRemoteDescription.
93 */ 93 */
94 public void onAddTrack(RtpReceiver receiver, MediaStream[] mediaStreams); 94 public void onAddTrack(MediaStreamTrack track, MediaStream[] mediaStreams);
Taylor Brandstetter 2017/08/29 19:48:09 It's not safe to change the signature of this; exi
korniltsev 2017/08/30 21:47:47 reverted it back
95
96 /**
97 * Triggered when a previously added remote track is removed by the remote p eer,
98 * as a result of setRemoteDescription.
99 */
100 void onRemoveTrack(MediaStreamTrack track, MediaStream[] mediaStreams);
Taylor Brandstetter 2017/08/29 19:48:09 Should be public. Also, can you give it an empty d
korniltsev 2017/08/30 21:47:47 Done.
95 } 101 }
96 102
97 /** Java version of PeerConnectionInterface.IceServer. */ 103 /** Java version of PeerConnectionInterface.IceServer. */
98 public static class IceServer { 104 public static class IceServer {
99 // List of URIs associated with this server. Valid formats are described 105 // List of URIs associated with this server. Valid formats are described
100 // in RFC7064 and RFC7065, and more may be added in the future. The "host" 106 // in RFC7064 and RFC7065, and more may be added in the future. The "host"
101 // part of the URI may contain either an IP address or a hostname. 107 // part of the URI may contain either an IP address or a hostname.
102 public final String uri; 108 public final String uri;
103 public final String username; 109 public final String username;
104 public final String password; 110 public final String password;
(...skipping 326 matching lines...) Expand 10 before | Expand all | Expand 10 after
431 private native RtpSender nativeCreateSender(String kind, String stream_id); 437 private native RtpSender nativeCreateSender(String kind, String stream_id);
432 438
433 private native List<RtpSender> nativeGetSenders(); 439 private native List<RtpSender> nativeGetSenders();
434 440
435 private native List<RtpReceiver> nativeGetReceivers(); 441 private native List<RtpReceiver> nativeGetReceivers();
436 442
437 private native boolean nativeStartRtcEventLog(int file_descriptor, int max_siz e_bytes); 443 private native boolean nativeStartRtcEventLog(int file_descriptor, int max_siz e_bytes);
438 444
439 private native void nativeStopRtcEventLog(); 445 private native void nativeStopRtcEventLog();
440 } 446 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698