Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 3007523002: Increase logging severity level for SW fallback. (Closed)

Created:
3 years, 4 months ago by brandtr
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Increase logging severity level for SW fallback. This will help debugging issues with the fallback, in cases where only LS_WARNING logs are available. BUG=none Review-Url: https://codereview.webrtc.org/3007523002 Cr-Commit-Position: refs/heads/master@{#19488} Committed: https://chromium.googlesource.com/external/webrtc/+/955d7f19e86953c58138b432774d375358817fd1

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Patch Set 4 : asapersson comments 1. #

Total comments: 2

Patch Set 5 : asapersson comments 2. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M webrtc/media/engine/videodecodersoftwarefallbackwrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/engine/videoencodersoftwarefallbackwrapper.cc View 1 2 3 4 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
brandtr
3 years, 4 months ago (2017-08-24 07:08:05 UTC) #2
brandtr
Rebase.
3 years, 4 months ago (2017-08-24 07:30:06 UTC) #3
brandtr
Rebase.
3 years, 4 months ago (2017-08-24 07:31:11 UTC) #4
brandtr
Addressed offline comments.
3 years, 4 months ago (2017-08-24 08:12:00 UTC) #5
åsapersson
lgtm https://codereview.webrtc.org/3007523002/diff/60001/webrtc/media/engine/videoencodersoftwarefallbackwrapper.cc File webrtc/media/engine/videoencodersoftwarefallbackwrapper.cc (right): https://codereview.webrtc.org/3007523002/diff/60001/webrtc/media/engine/videoencodersoftwarefallbackwrapper.cc#newcode153 webrtc/media/engine/videoencodersoftwarefallbackwrapper.cc:153: << "Encode OK, no longer using the software ...
3 years, 4 months ago (2017-08-24 08:21:32 UTC) #6
brandtr
https://codereview.webrtc.org/3007523002/diff/60001/webrtc/media/engine/videoencodersoftwarefallbackwrapper.cc File webrtc/media/engine/videoencodersoftwarefallbackwrapper.cc (right): https://codereview.webrtc.org/3007523002/diff/60001/webrtc/media/engine/videoencodersoftwarefallbackwrapper.cc#newcode153 webrtc/media/engine/videoencodersoftwarefallbackwrapper.cc:153: << "Encode OK, no longer using the software fallback ...
3 years, 4 months ago (2017-08-24 10:24:51 UTC) #7
brandtr
+magjed for OWNER
3 years, 4 months ago (2017-08-24 10:25:36 UTC) #9
magjed_webrtc
lgtm
3 years, 4 months ago (2017-08-24 10:54:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3007523002/80001
3 years, 4 months ago (2017-08-24 11:25:27 UTC) #13
commit-bot: I haz the power
3 years, 4 months ago (2017-08-24 12:20:04 UTC) #16
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/955d7f19e86953c58138b4327...

Powered by Google App Engine
This is Rietveld 408576698