Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 3007243002: Add and modify a few ANA stats. (Closed)

Created:
3 years, 3 months ago by ivoc
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, yujie_mao (webrtc), kwiberg-webrtc, hlundin-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc, the sun, AleBzk
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add and modify a few ANA stats. This CL adds seperate counters for ANA frame length increases and decreases, which gives more insight into what actions are taken. In addition, a new stat is added to track the sum of the uplink packet loss fraction that is set by the ANA FEC controller. BUG=webrtc:8127 Review-Url: https://codereview.webrtc.org/3007243002 Cr-Commit-Position: refs/heads/master@{#19756} Committed: https://chromium.googlesource.com/external/webrtc/+/0d0b9121282c3f63aaaa242779122f5b0c5db96c

Patch Set 1 #

Patch Set 2 : Added missing assignments in statscollector_unittest.cc #

Patch Set 3 : Changed uplink packet loss fraction stat to an instantaneous value instead of a sum. #

Patch Set 4 : Update to changes in upstream CL. #

Patch Set 5 : Change uplink fraction to float. #

Patch Set 6 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -21 lines) Patch
M webrtc/api/audio_codecs/audio_encoder.h View 1 2 3 4 5 1 chunk +11 lines, -4 lines 0 comments Download
M webrtc/api/statstypes.h View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/api/statstypes.cc View 1 2 3 4 5 1 chunk +6 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine_unittest.cc View 1 2 3 4 2 chunks +11 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc View 1 2 3 1 chunk +6 lines, -2 lines 0 comments Download
M webrtc/pc/statscollector.cc View 1 2 3 4 5 1 chunk +11 lines, -3 lines 0 comments Download
M webrtc/pc/statscollector_unittest.cc View 1 2 3 4 2 chunks +24 lines, -6 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (7 generated)
ivoc
Hi guys, I made a small CL to split one of the new ANA stats, ...
3 years, 3 months ago (2017-09-07 10:50:12 UTC) #2
ivoc
After some offline discussion with Alex, we decided to change the uplink packet loss fraction ...
3 years, 3 months ago (2017-09-07 12:23:51 UTC) #3
alexnarest
lgtm The actual collection code is in other CL?
3 years, 3 months ago (2017-09-07 12:59:59 UTC) #4
stefan-webrtc
lgtm
3 years, 3 months ago (2017-09-08 09:42:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3007243002/100001
3 years, 3 months ago (2017-09-08 15:15:11 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_api_framework on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_api_framework/builds/11252)
3 years, 3 months ago (2017-09-08 15:29:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3007243002/100001
3 years, 3 months ago (2017-09-08 20:14:28 UTC) #12
commit-bot: I haz the power
3 years, 3 months ago (2017-09-08 20:24:28 UTC) #15
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/external/webrtc/+/0d0b9121282c3f63aaaa24277...

Powered by Google App Engine
This is Rietveld 408576698