Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 3007153003: Enable UBSan float-cast-overflow warnings and fix existing ones (Closed)

Created:
3 years, 3 months ago by oprypin_webrtc
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, niklas.enbom, peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable UBSan float-cast-overflow warnings and fix existing ones BUG=webrtc:8204 Review-Url: https://codereview.webrtc.org/3007153003 Cr-Commit-Position: refs/heads/master@{#19694} Committed: https://chromium.googlesource.com/external/webrtc/+/30431d5acd6225dc66f4fe49498376377f4f87e9

Patch Set 1 : Enable float-cast-overflow for is_ubsan #

Patch Set 2 : gn format #

Patch Set 3 : Fix/silence existing warnings #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M webrtc/BUILD.gn View 1 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/media/base/rtpdataengine.cc View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/level_controller/level_controller.cc View 1 2 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 18 (12 generated)
saza WebRTC
https://codereview.webrtc.org/3007153003/diff/40001/webrtc/modules/audio_processing/level_controller/level_controller.cc File webrtc/modules/audio_processing/level_controller/level_controller.cc (right): https://codereview.webrtc.org/3007153003/diff/40001/webrtc/modules/audio_processing/level_controller/level_controller.cc#newcode52 webrtc/modules/audio_processing/level_controller/level_controller.cc:52: audio.channels_const_f()[k] + audio.num_frames(), 0.f, Good find. Fyi, aleloi@ or ...
3 years, 3 months ago (2017-09-05 09:35:20 UTC) #4
oprypin_webrtc
3 years, 3 months ago (2017-09-05 11:03:08 UTC) #9
kwiberg-webrtc
lgtm
3 years, 3 months ago (2017-09-05 11:07:58 UTC) #10
kjellander_webrtc
lgtm
3 years, 3 months ago (2017-09-05 15:49:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3007153003/40001
3 years, 3 months ago (2017-09-05 16:46:41 UTC) #15
commit-bot: I haz the power
3 years, 3 months ago (2017-09-05 16:49:39 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/30431d5acd6225dc66f4fe494...

Powered by Google App Engine
This is Rietveld 408576698