Delete remnants of RTX support in voice_engine.

Delete remnants of RTX support in voice_engine.

Receive logic in voe::Channel attempted to handle RTX if
RTPPayloadRegistry::IsRtx returns true, but the audio code never calls
the config methods (SetRtxSsrc or SetRtxPayloadType) required for that
to ever happen.

BUG=webrtc:7135
Review-Url: https://codereview.webrtc.org/3006913002
Cr-Commit-Position: refs/heads/master@{#19633}
Committed: https://chromium.googlesource.com/external/webrtc/+/da194e79c4a86869e8afccf9827c716f0b073fb1

[nisse-webrtc, 2017-08-31 07:54:45]

nisse@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[nisse-webrtc, 2017-08-31 07:54:46]

At closer look, the audio rtx support appears to be dead code. Is there any
other tracking bug relevant for this deletion?

[the sun, 2017-08-31 13:10:00]

solenberg@webrtc.org changed reviewers:
+ minyue@webrtc.org

[the sun, 2017-08-31 13:10:01]

LGTM, but looping in minyue@ for a sanity check

[minyue-webrtc, 2017-08-31 13:24:06]

lgtm

https://codereview.webrtc.org/3006913002/diff/20001/webrtc/voice_engine/chann...
File webrtc/voice_engine/channel.h (left):

https://codereview.webrtc.org/3006913002/diff/20001/webrtc/voice_engine/chann...
webrtc/voice_engine/channel.h:532: // DTX.
I think this comment should have been RTX :)

[nisse-webrtc, 2017-08-31 13:39:08]

https://codereview.webrtc.org/3006913002/diff/20001/webrtc/voice_engine/chann...
File webrtc/voice_engine/channel.h (left):

https://codereview.webrtc.org/3006913002/diff/20001/webrtc/voice_engine/chann...
webrtc/voice_engine/channel.h:532: // DTX.
On 2017/08/31 13:24:05, minyue-webrtc wrote:
> I think this comment should have been RTX :)

That's my guess too :-)

[nisse-webrtc, 2017-08-31 13:39:12]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2017-08-31 13:39:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-31 14:26:17]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1504186752543590,
"parent_rev": "9868042b053d52c45c632f09c1d22cb13bc1ad41", "commit_rev":
"da194e79c4a86869e8afccf9827c716f0b073fb1"}

[commit-bot: I haz the power, 2017-08-31 14:26:23]

Description was changed from

==========
Delete remnants of RTX support in voice_engine.

Receive logic in voe::Channel attempted to handle RTX if
RTPPayloadRegistry::IsRtx returns true, but the audio code never calls
the config methods (SetRtxSsrc or SetRtxPayloadType) required for that
to ever happen.

BUG=webrtc:7135
==========

to

==========
Delete remnants of RTX support in voice_engine.

Receive logic in voe::Channel attempted to handle RTX if
RTPPayloadRegistry::IsRtx returns true, but the audio code never calls
the config methods (SetRtxSsrc or SetRtxPayloadType) required for that
to ever happen.

BUG=webrtc:7135

Review-Url: https://codereview.webrtc.org/3006913002
Cr-Commit-Position: refs/heads/master@{#19633}
Committed:
https://chromium.googlesource.com/external/webrtc/+/da194e79c4a86869e8afccf98...
==========

[commit-bot: I haz the power, 2017-08-31 14:26:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/da194e79c4a86869e8afccf98...