Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 3006803002: Removes unused APIs from the ADM (part II) (Closed)

Created:
3 years, 3 months ago by henrika_webrtc
Modified:
3 years, 3 months ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removes unused APIs from the ADM (part II). Removes: int32_t SpeakerVolumeStepSize(uint16_t* stepSize) int32_t MicrophoneVolumeStepSize(uint16_t* stepSize) int32_t MicrophoneBoostIsAvailable(bool* available) int32_t SetMicrophoneBoost(bool enable) int32_t MicrophoneBoost(bool* enabled) int32_t SetPlayoutBuffer(const BufferType type, uint16_t sizeMS = 0) int32_t PlayoutBuffer(BufferType* type, uint16_t* sizeMS) int32_t CPULoad(uint16_t* load) int32_t StartRawOutputFileRecording(const char pcmFileNameUTF8[kAdmMaxFileNameSize]) int32_t StopRawOutputFileRecording() int32_t StartRawInputFileRecording(const char pcmFileNameUTF8[kAdmMaxFileNameSize]) int32_t StopRawInputFileRecording() int32_t ResetAudioDevice() BUG=webrtc:7306 Review-Url: https://codereview.webrtc.org/3006803002 Cr-Commit-Position: refs/heads/master@{#19632} Committed: https://chromium.googlesource.com/external/webrtc/+/9868042b053d52c45c632f09c1d22cb13bc1ad41

Patch Set 1 #

Patch Set 2 : Deprecates PlayoutBuffer APIs #

Patch Set 3 : fixes #

Patch Set 4 : Mac now compiles as well #

Patch Set 5 : Fixes building on Mac #

Patch Set 6 : Removed CPULoad() API #

Patch Set 7 : Removes file recording APIs #

Patch Set 8 : Removes ResetAudioDevice API #

Total comments: 1

Patch Set 9 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -1567 lines) Patch
M webrtc/modules/audio_device/android/audio_device_template.h View 1 2 3 4 5 5 chunks +0 lines, -42 lines 0 comments Download
M webrtc/modules/audio_device/audio_device_buffer.h View 1 2 3 4 5 6 1 chunk +0 lines, -8 lines 0 comments Download
M webrtc/modules/audio_device/audio_device_buffer.cc View 1 2 3 4 5 6 1 chunk +0 lines, -22 lines 0 comments Download
M webrtc/modules/audio_device/audio_device_data_observer.cc View 1 2 3 4 5 6 7 5 chunks +0 lines, -39 lines 0 comments Download
M webrtc/modules/audio_device/audio_device_generic.h View 1 2 3 4 5 6 7 5 chunks +0 lines, -23 lines 0 comments Download
M webrtc/modules/audio_device/audio_device_generic.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -13 lines 0 comments Download
M webrtc/modules/audio_device/audio_device_impl.h View 1 2 3 4 5 6 7 5 chunks +0 lines, -21 lines 0 comments Download
M webrtc/modules/audio_device/audio_device_impl.cc View 1 2 3 4 5 6 7 6 chunks +0 lines, -235 lines 0 comments Download
M webrtc/modules/audio_device/dummy/audio_device_dummy.h View 1 2 3 4 5 4 chunks +0 lines, -14 lines 0 comments Download
M webrtc/modules/audio_device/dummy/audio_device_dummy.cc View 1 2 3 4 5 4 chunks +0 lines, -29 lines 0 comments Download
M webrtc/modules/audio_device/dummy/file_audio_device.h View 1 2 3 4 5 5 chunks +0 lines, -15 lines 0 comments Download
M webrtc/modules/audio_device/dummy/file_audio_device.cc View 1 2 3 4 5 4 chunks +0 lines, -30 lines 0 comments Download
M webrtc/modules/audio_device/include/audio_device.h View 1 2 3 4 5 6 7 6 chunks +35 lines, -17 lines 0 comments Download
M webrtc/modules/audio_device/include/fake_audio_device.h View 1 2 3 4 5 6 7 3 chunks +0 lines, -26 lines 0 comments Download
M webrtc/modules/audio_device/include/mock_audio_device.h View 1 2 3 4 5 6 7 2 chunks +0 lines, -17 lines 0 comments Download
M webrtc/modules/audio_device/ios/audio_device_ios.h View 1 2 3 4 5 6 7 2 chunks +0 lines, -11 lines 0 comments Download
M webrtc/modules/audio_device/ios/audio_device_not_implemented_ios.mm View 1 2 3 4 5 6 7 5 chunks +0 lines, -48 lines 0 comments Download
M webrtc/modules/audio_device/linux/audio_device_alsa_linux.h View 1 2 3 4 5 6 chunks +9 lines, -28 lines 0 comments Download
M webrtc/modules/audio_device/linux/audio_device_alsa_linux.cc View 1 2 3 4 5 6 chunks +1 line, -127 lines 0 comments Download
M webrtc/modules/audio_device/linux/audio_device_pulse_linux.h View 1 2 3 4 5 6 chunks +0 lines, -18 lines 0 comments Download
M webrtc/modules/audio_device/linux/audio_device_pulse_linux.cc View 1 2 3 4 5 6 chunks +0 lines, -105 lines 0 comments Download
M webrtc/modules/audio_device/linux/audio_mixer_manager_alsa_linux.h View 2 chunks +0 lines, -5 lines 0 comments Download
M webrtc/modules/audio_device/linux/audio_mixer_manager_alsa_linux.cc View 3 chunks +0 lines, -89 lines 0 comments Download
M webrtc/modules/audio_device/linux/audio_mixer_manager_pulse_linux.h View 2 chunks +0 lines, -5 lines 0 comments Download
M webrtc/modules/audio_device/linux/audio_mixer_manager_pulse_linux.cc View 3 chunks +0 lines, -122 lines 0 comments Download
M webrtc/modules/audio_device/mac/audio_device_mac.h View 1 2 3 4 5 6 chunks +0 lines, -18 lines 0 comments Download
M webrtc/modules/audio_device/mac/audio_device_mac.cc View 1 2 3 4 5 6 7 8 7 chunks +3 lines, -98 lines 0 comments Download
M webrtc/modules/audio_device/mac/audio_mixer_manager_mac.h View 2 chunks +0 lines, -5 lines 0 comments Download
M webrtc/modules/audio_device/mac/audio_mixer_manager_mac.cc View 3 chunks +0 lines, -73 lines 0 comments Download
M webrtc/modules/audio_device/win/audio_device_core_win.h View 1 2 3 4 5 7 chunks +0 lines, -16 lines 0 comments Download
M webrtc/modules/audio_device/win/audio_device_core_win.cc View 1 2 3 4 5 6 7 13 chunks +0 lines, -157 lines 0 comments Download
M webrtc/pc/test/fakeaudiocapturemodule.h View 1 2 3 4 5 6 7 4 chunks +0 lines, -19 lines 0 comments Download
M webrtc/pc/test/fakeaudiocapturemodule.cc View 1 2 3 4 5 6 7 6 chunks +0 lines, -72 lines 0 comments Download

Messages

Total messages: 44 (40 generated)
henrika_webrtc
PTAL (PS, failing bots are flake)
3 years, 3 months ago (2017-08-31 10:45:51 UTC) #32
the sun
LGTM % comment https://codereview.webrtc.org/3006803002/diff/140001/webrtc/modules/audio_device/mac/audio_device_mac.cc File webrtc/modules/audio_device/mac/audio_device_mac.cc (right): https://codereview.webrtc.org/3006803002/diff/140001/webrtc/modules/audio_device/mac/audio_device_mac.cc#newcode1886 webrtc/modules/audio_device/mac/audio_device_mac.cc:1886: const uint16_t playBufDelayFixed = 20; kPlayBufDelayFixed ...
3 years, 3 months ago (2017-08-31 13:04:11 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3006803002/160001
3 years, 3 months ago (2017-08-31 13:13:14 UTC) #41
commit-bot: I haz the power
3 years, 3 months ago (2017-08-31 13:47:41 UTC) #44
Message was sent while issue was closed.
Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/external/webrtc/+/9868042b053d52c45c632f09c...

Powered by Google App Engine
This is Rietveld 408576698