Removes unused WaveOut APIs from ADM

Removes unused WaveOut APIs from ADM.

Will remove default implementations as well once landed and removed
in Chrome as well.

These two AudioDeviceModule APIs are removed:

int32_t SetWaveOutVolume(uint16_t volumeLeft, uint16_t volumeRight)
int32_t WaveOutVolume(uint16_t* volumeLeft, uint16_t* volumeRight) const

BUG=webrtc:7306
Review-Url: https://codereview.webrtc.org/3006793002
Cr-Commit-Position: refs/heads/master@{#19581}
Committed: https://chromium.googlesource.com/external/webrtc/+/ecf312e60356dd4df999a0675e7d1cf85e0dd495

[henrika_webrtc, 2017-08-29 11:48:35]

Description was changed from

==========
Removes unused WaveOut APIs from ADM

Removes unused WaveOut APIs from ADM

BUG=
==========

to

==========
Removes unused WaveOut APIs from ADM.

Will remove default implementations as well once landed and removed
in Chrome as well.

BUG=webrtc:7306
==========

[henrika_webrtc, 2017-08-29 11:48:36]

henrika@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[henrika_webrtc, 2017-08-29 11:48:52]

The CQ bit was checked by henrika@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-29 11:49:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[henrika_webrtc, 2017-08-29 11:51:39]

Description was changed from

==========
Removes unused WaveOut APIs from ADM.

Will remove default implementations as well once landed and removed
in Chrome as well.

BUG=webrtc:7306
==========

to

==========
Removes unused WaveOut APIs from ADM.

Will remove default implementations as well once landed and removed
in Chrome as well.

These two AudioDeviceModule APIs are removed:

int32_t SetWaveOutVolume(uint16_t volumeLeft, uint16_t volumeRight)
int32_t WaveOutVolume(uint16_t* volumeLeft, uint16_t* volumeRight) const

BUG=webrtc:7306
==========

[henrika_webrtc, 2017-08-29 12:03:28]

PTAL

[commit-bot: I haz the power, 2017-08-29 12:52:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-29 12:52:33]

Dry run: This issue passed the CQ dry run.

[The Sun (google.com), 2017-08-29 12:56:42]

solenberg@google.com changed reviewers:
+ solenberg@google.com

[The Sun (google.com), 2017-08-29 12:56:43]

lgtm

https://codereview.webrtc.org/3006793002/diff/1/webrtc/modules/audio_device/i...
File webrtc/modules/audio_device/include/audio_device.h (right):

https://codereview.webrtc.org/3006793002/diff/1/webrtc/modules/audio_device/i...
webrtc/modules/audio_device/include/audio_device.h:113: virtual int32_t
SetWaveOutVolume(uint16_t volumeLeft,
Is it possible to remove them directly? I can only see there being a problem if
an external impl uses "override".

[henrika_webrtc, 2017-08-29 12:59:11]

Some do just that ;-(

https://cs.chromium.org/chromium/src/remoting/protocol/webrtc_audio_module.h?...

[henrika_webrtc, 2017-08-29 12:59:54]

The CQ bit was checked by henrika@webrtc.org

[commit-bot: I haz the power, 2017-08-29 13:00:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-29 13:02:12]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1504011594349680, "parent_rev":
"9b2f20c6187f29e0c5105ff436b2fc787f924976", "commit_rev":
"ecf312e60356dd4df999a0675e7d1cf85e0dd495"}

[commit-bot: I haz the power, 2017-08-29 13:02:20]

Description was changed from

==========
Removes unused WaveOut APIs from ADM.

Will remove default implementations as well once landed and removed
in Chrome as well.

These two AudioDeviceModule APIs are removed:

int32_t SetWaveOutVolume(uint16_t volumeLeft, uint16_t volumeRight)
int32_t WaveOutVolume(uint16_t* volumeLeft, uint16_t* volumeRight) const

BUG=webrtc:7306
==========

to

==========
Removes unused WaveOut APIs from ADM.

Will remove default implementations as well once landed and removed
in Chrome as well.

These two AudioDeviceModule APIs are removed:

int32_t SetWaveOutVolume(uint16_t volumeLeft, uint16_t volumeRight)
int32_t WaveOutVolume(uint16_t* volumeLeft, uint16_t* volumeRight) const

BUG=webrtc:7306

Review-Url: https://codereview.webrtc.org/3006793002
Cr-Commit-Position: refs/heads/master@{#19581}
Committed:
https://chromium.googlesource.com/external/webrtc/+/ecf312e60356dd4df999a0675...
==========

[commit-bot: I haz the power, 2017-08-29 13:02:21]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/ecf312e60356dd4df999a0675...