Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 3006583002: Removing references to webrtc/base in DEPS files. (Closed)

Created:
3 years, 3 months ago by mbonadei
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), zhuangzesen_agora.io, aleloi, tlegrand-webrtc, qiang.lu, peah-webrtc, bjornv1, video-team_agora.io, AleBzk, tterriberry_mozilla.com, fengyue_agora.io, sdk-team_agora.io, minyue-webrtc, mflodman, Andrew MacDonald, zhengzhonghou_agora.io, stefan-webrtc, kwiberg-webrtc, danilchap, henrika_webrtc, audio-team_agora.io, hlundin-webrtc, niklas.enbom, the sun, perkj_webrtc, aluebs-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Recently we moved webrtc/base to webrtc/rtc_base, so these directives in our DEPS files are not needed anymore. Includes from webrtc/rtc_base are also whitelisted in webrtc/DEPS so we don't have to whitelist it in all the others DEPS files. BUG=webrtc:7634 NOTRY=True Review-Url: https://codereview.webrtc.org/3006583002 Cr-Commit-Position: refs/heads/master@{#19601} Committed: https://chromium.googlesource.com/external/webrtc/+/16adf03d2555f186ae7c986a405c657c35aaca6d

Patch Set 1 #

Patch Set 2 : Resolving merge conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -35 lines) Patch
M webrtc/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/audio/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/call/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/common_audio/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/common_video/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/examples/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/logging/rtc_event_log/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/media/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_conference_mixer/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_device/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_mixer/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/bitrate_controller/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/congestion_controller/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/desktop_capture/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/include/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/media_file/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/pacing/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/utility/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_capture/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_processing/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/ortc/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/p2p/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/pc/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/rtc_tools/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/stats/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/system_wrappers/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/voice_engine/DEPS View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 23 (13 generated)
mbonadei
3 years, 3 months ago (2017-08-25 09:42:14 UTC) #3
kjellander_webrtc
lgtm I suggest NOTRY=True
3 years, 3 months ago (2017-08-25 11:13:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3006583002/1
3 years, 3 months ago (2017-08-25 11:45:00 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/20730)
3 years, 3 months ago (2017-08-25 11:50:10 UTC) #9
tommi
lgtm - can you update the CL description to also explain why this is needed ...
3 years, 3 months ago (2017-08-30 09:43:11 UTC) #11
mbonadei
On 2017/08/30 09:43:11, tommi wrote: > lgtm - can you update the CL description to ...
3 years, 3 months ago (2017-08-30 09:51:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3006583002/1
3 years, 3 months ago (2017-08-30 09:51:29 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/20957)
3 years, 3 months ago (2017-08-30 09:55:20 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3006583002/20001
3 years, 3 months ago (2017-08-30 11:43:43 UTC) #20
commit-bot: I haz the power
3 years, 3 months ago (2017-08-30 11:46:07 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/16adf03d2555f186ae7c986a4...

Powered by Google App Engine
This is Rietveld 408576698