Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
3006413002:
Delete deprecated metod RtpRtcp::SetMaxTransferUnit. (Closed)
|
Created:
3 years, 3 months ago by nisse-webrtc Modified:
3 years, 3 months ago Reviewers:
danilchap CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionDelete deprecated metod RtpRtcp::SetMaxTransferUnit.
Deprecated since cl https://codereview.webrtc.org/2589743002
BUG=webrtc:6847
Review-Url: https://codereview.webrtc.org/3006413002
Cr-Commit-Position: refs/heads/master@{#19878}
Committed: https://webrtc.googlesource.com/src/+/435472542a2ae07a22897263a8441234ec336c82
Patch Set 1 #Patch Set 2 : Rebased. #Patch Set 3 : Rebase after The Great Move. #Messages
Total messages: 39 (26 generated)
Description was changed from ========== Delete deprecated metod RtpRtcp::SetMaxTransferUnit. BUG=webrtc:6847 ========== to ========== Delete deprecated metod RtpRtcp::SetMaxTransferUnit. Deprecated since cl https://codereview.webrtc.org/2589743002 BUG=webrtc:6847 ==========
nisse@webrtc.org changed reviewers: + danilchap@webrtc.org
lgtm
The CQ bit was checked by nisse@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1505369048093030, "parent_rev":
"7a5bcdffaab90a05bc1146b2b1ea71c004e54d71", "commit_rev":
"e33a2e542eba2c7ebcc7581d98a1a180f83bcc8e"}
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1505369048093030, "parent_rev":
"7a5bcdffaab90a05bc1146b2b1ea71c004e54d71", "commit_rev":
"e33a2e542eba2c7ebcc7581d98a1a180f83bcc8e"}
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1505369048093030, "parent_rev":
"7a5bcdffaab90a05bc1146b2b1ea71c004e54d71", "commit_rev":
"e33a2e542eba2c7ebcc7581d98a1a180f83bcc8e"}
The CQ bit was unchecked by commit-bot@chromium.org
Failed to commit the patch.
The CQ bit was checked by nisse@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1505387366752880, "parent_rev":
"7a5bcdffaab90a05bc1146b2b1ea71c004e54d71", "commit_rev":
"a862bf658af9e49910be6a39cc3281272096b8d6"}
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1505387366752880, "parent_rev":
"7a5bcdffaab90a05bc1146b2b1ea71c004e54d71", "commit_rev":
"a862bf658af9e49910be6a39cc3281272096b8d6"}
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1505387366752880, "parent_rev":
"7a5bcdffaab90a05bc1146b2b1ea71c004e54d71", "commit_rev":
"a862bf658af9e49910be6a39cc3281272096b8d6"}
The CQ bit was unchecked by commit-bot@chromium.org
Failed to commit the patch.
The CQ bit was checked by nisse@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from danilchap@webrtc.org Link to the patchset: https://codereview.webrtc.org/3006413002/#ps20001 (title: "Rebased.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1505388754645930,
"parent_rev": "7a5bcdffaab90a05bc1146b2b1ea71c004e54d71", "commit_rev":
"1db0f3aaf0f1240f8ec043cda98bd6aad7579754"}
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1505388754645930,
"parent_rev": "7a5bcdffaab90a05bc1146b2b1ea71c004e54d71", "commit_rev":
"1db0f3aaf0f1240f8ec043cda98bd6aad7579754"}
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1505388754645930,
"parent_rev": "7a5bcdffaab90a05bc1146b2b1ea71c004e54d71", "commit_rev":
"1db0f3aaf0f1240f8ec043cda98bd6aad7579754"}
The CQ bit was unchecked by commit-bot@chromium.org
Failed to commit the patch.
The CQ bit was checked by nisse@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/21659)
The CQ bit was checked by nisse@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from danilchap@webrtc.org Link to the patchset: https://codereview.webrtc.org/3006413002/#ps40001 (title: "Rebase after The Great Move.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/21718)
The CQ bit was checked by nisse@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1505715778272650,
"parent_rev": "cb3b1c13f7ad8ba7be2c221ca474a1502f0bb5a5", "commit_rev":
"435472542a2ae07a22897263a8441234ec336c82"}
Message was sent while issue was closed.
Description was changed from ========== Delete deprecated metod RtpRtcp::SetMaxTransferUnit. Deprecated since cl https://codereview.webrtc.org/2589743002 BUG=webrtc:6847 ========== to ========== Delete deprecated metod RtpRtcp::SetMaxTransferUnit. Deprecated since cl https://codereview.webrtc.org/2589743002 BUG=webrtc:6847 Review-Url: https://codereview.webrtc.org/3006413002 Cr-Commit-Position: refs/heads/master@{#19878} Committed: https://webrtc.googlesource.com/src/+/435472542a2ae07a22897263a8441234ec336c82 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://webrtc.googlesource.com/src/+/435472542a2ae07a22897263a8441234ec336c82 |
