Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3006383002: Remove VoERTP_RTCP (Closed)

Created:
3 years, 3 months ago by the sun
Modified:
3 years, 3 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, AleBzk, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove VoERTP_RTCP. BUG=webrtc:4690 Review-Url: https://codereview.webrtc.org/3006383002 Cr-Commit-Position: refs/heads/master@{#19892} Committed: https://webrtc.googlesource.com/src/+/dd3abbb53250072dc5baac0391ebea135be6fa53

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase+remove #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -547 lines) Patch
M test/mock_voice_engine.h View 1 2 3 1 chunk +0 lines, -38 lines 0 comments Download
M voice_engine/BUILD.gn View 1 2 3 2 chunks +0 lines, -3 lines 0 comments Download
M voice_engine/channel.h View 1 2 3 4 chunks +29 lines, -12 lines 0 comments Download
M voice_engine/channel.cc View 1 2 3 4 chunks +0 lines, -75 lines 0 comments Download
M voice_engine/channel_proxy.h View 1 2 3 2 chunks +1 line, -3 lines 0 comments Download
D voice_engine/include/voe_rtp_rtcp.h View 1 2 1 chunk +0 lines, -151 lines 0 comments Download
D voice_engine/voe_rtp_rtcp_impl.h View 1 2 1 chunk +0 lines, -55 lines 0 comments Download
D voice_engine/voe_rtp_rtcp_impl.cc View 1 2 1 chunk +0 lines, -201 lines 0 comments Download
M voice_engine/voice_engine_defines.h View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M voice_engine/voice_engine_impl.h View 1 2 3 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
the sun
3 years, 3 months ago (2017-09-18 12:51:10 UTC) #3
kwiberg-webrtc
lgtm
3 years, 3 months ago (2017-09-18 12:57:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3006383002/60001
3 years, 3 months ago (2017-09-18 13:02:57 UTC) #6
commit-bot: I haz the power
3 years, 3 months ago (2017-09-18 14:05:36 UTC) #9
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://webrtc.googlesource.com/src/+/dd3abbb53250072dc5baac0391ebea135be6fa53

Powered by Google App Engine
This is Rietveld 408576698